From efb0cbb4a7b2fc3319ebc54e40ab63457937380d Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 14 Feb 2023 19:12:54 +0100 Subject: Add missing return after PAC parsing exception Otherwise, 'pacscript' in the line below would cause a NameError --- qutebrowser/browser/network/pac.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qutebrowser/browser/network/pac.py b/qutebrowser/browser/network/pac.py index 99078ab20..be2ec3093 100644 --- a/qutebrowser/browser/network/pac.py +++ b/qutebrowser/browser/network/pac.py @@ -287,6 +287,8 @@ class PACFetcher(QObject): error = "Invalid encoding of a PAC file: {}" self._error_message = error.format(e) log.network.exception(self._error_message) + return + try: self._pac = PACResolver(pacscript) log.network.debug("Successfully evaluated PAC file.") @@ -294,6 +296,7 @@ class PACFetcher(QObject): error = "Error in PAC evaluation: {}" self._error_message = error.format(e) log.network.exception(self._error_message) + self._manager = None self._reply = None self.finished.emit() -- cgit v1.2.3-54-g00ecf