summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoofar <toofar@spalge.com>2022-09-11 13:39:53 +1200
committertoofar <toofar@spalge.com>2022-09-11 17:22:50 +1200
commitbaeb05d6a2403a83c134d6465eac922ce8c87cde (patch)
treeda888357c3262273f8c6d1de8b6a10018e0f2de7
parentb0e3dcef819d9e24361051d2dc85f6f0e8762aa6 (diff)
downloadqutebrowser-baeb05d6a2403a83c134d6465eac922ce8c87cde.tar.gz
qutebrowser-baeb05d6a2403a83c134d6465eac922ce8c87cde.zip
mypy: handle none case in Optional: downloads.reply
I'm not sure how theoretical this case is. There is a comment somewhere else indicating the reply can "disappear".
-rw-r--r--qutebrowser/browser/qtnetworkdownloads.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/qutebrowser/browser/qtnetworkdownloads.py b/qutebrowser/browser/qtnetworkdownloads.py
index 586570390..242565a39 100644
--- a/qutebrowser/browser/qtnetworkdownloads.py
+++ b/qutebrowser/browser/qtnetworkdownloads.py
@@ -177,7 +177,10 @@ class DownloadItem(downloads.AbstractDownloadItem):
@pyqtSlot(QUrl)
def _on_redirected(self, url):
- log.downloads.debug(f"redirected: {self._reply.url()} -> {url}")
+ if self._reply is None:
+ log.downloads.warning(f"redirected: REPLY GONE -> {url}")
+ else:
+ log.downloads.debug(f"redirected: {self._reply.url()} -> {url}")
def _do_cancel(self):
self._read_timer.stop()