From baeb05d6a2403a83c134d6465eac922ce8c87cde Mon Sep 17 00:00:00 2001 From: toofar Date: Sun, 11 Sep 2022 13:39:53 +1200 Subject: mypy: handle none case in Optional: downloads.reply I'm not sure how theoretical this case is. There is a comment somewhere else indicating the reply can "disappear". --- qutebrowser/browser/qtnetworkdownloads.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/qtnetworkdownloads.py b/qutebrowser/browser/qtnetworkdownloads.py index 586570390..242565a39 100644 --- a/qutebrowser/browser/qtnetworkdownloads.py +++ b/qutebrowser/browser/qtnetworkdownloads.py @@ -177,7 +177,10 @@ class DownloadItem(downloads.AbstractDownloadItem): @pyqtSlot(QUrl) def _on_redirected(self, url): - log.downloads.debug(f"redirected: {self._reply.url()} -> {url}") + if self._reply is None: + log.downloads.warning(f"redirected: REPLY GONE -> {url}") + else: + log.downloads.debug(f"redirected: {self._reply.url()} -> {url}") def _do_cancel(self): self._read_timer.stop() -- cgit v1.2.3-54-g00ecf