diff options
author | Micah Lee <micah@micahflee.com> | 2018-12-11 12:50:40 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-11 12:50:40 -0800 |
commit | 4da5e15581a69509e7bfc6c4d0742052e0b61b24 (patch) | |
tree | 3ea3382892aa943e66f43f9fdeeacffc22944814 | |
parent | 2ad1f77f91748d3ba0a9efb1e4892448413d4c21 (diff) | |
parent | 919fdeb096b957e29382113e41270bbaf533b0fb (diff) | |
download | onionshare-4da5e15581a69509e7bfc6c4d0742052e0b61b24.tar.gz onionshare-4da5e15581a69509e7bfc6c4d0742052e0b61b24.zip |
Merge pull request #838 from micahflee/837_hotfix_cve-2018-19960
When debug mode is enabled, don't log flask errors to disk
-rw-r--r-- | onionshare/web.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/onionshare/web.py b/onionshare/web.py index 702ba686..e9c4d43b 100644 --- a/onionshare/web.py +++ b/onionshare/web.py @@ -178,12 +178,19 @@ def set_gui_mode(): def debug_mode(): """ Turn on debugging mode, which will log flask errors to a debug file. + + This is commented out (it's only needed for debugging, and not needed + for OnionShare 1.3.2) as a hotfix to resolve this issue: + https://github.com/micahflee/onionshare/issues/837 + """ + pass """ temp_dir = tempfile.gettempdir() log_handler = logging.FileHandler( os.path.join(temp_dir, 'onionshare_server.log')) log_handler.setLevel(logging.WARNING) app.logger.addHandler(log_handler) + """ def check_slug_candidate(slug_candidate, slug_compare=None): |