diff options
| author | Miguel Jacq <mig@mig5.net> | 2021-05-11 08:41:56 +1000 |
|---|---|---|
| committer | Miguel Jacq <mig@mig5.net> | 2021-05-11 08:41:56 +1000 |
| commit | 3394571fadcb4c6b20d1c7255d99dc668f06c58d (patch) | |
| tree | 5ee43fb6c020c6c9c81d463cfee92888b658afe5 | |
| parent | 0b6db6559dff6ee314fe7fa9f68d2682d8abda9c (diff) | |
| download | onionshare-3394571fadcb4c6b20d1c7255d99dc668f06c58d.tar.gz onionshare-3394571fadcb4c6b20d1c7255d99dc668f06c58d.zip | |
Add the 'Test 405 HTTP response for bad methods' test to the Chat mode GUI tests, which uncovered the exception that the previous commit fixes
| -rw-r--r-- | desktop/tests/test_gui_chat.py | 27 |
1 files changed, 23 insertions, 4 deletions
diff --git a/desktop/tests/test_gui_chat.py b/desktop/tests/test_gui_chat.py index 7a19168b..50110100 100644 --- a/desktop/tests/test_gui_chat.py +++ b/desktop/tests/test_gui_chat.py @@ -47,7 +47,7 @@ class TestChat(GuiBaseTest): self.assertTrue(jsonResponse["success"]) self.assertEqual(jsonResponse["username"], "oniontest") - def run_all_chat_mode_tests(self, tab): + def run_all_chat_mode_started_tests(self, tab): """Tests in chat mode after starting a chat""" self.server_working_on_start_button_pressed(tab) self.server_status_indicator_says_starting(tab) @@ -58,8 +58,9 @@ class TestChat(GuiBaseTest): self.have_copy_url_button(tab) self.have_show_qr_code_button(tab) self.server_status_indicator_says_started(tab) - self.view_chat(tab) - self.change_username(tab) + + def run_all_chat_mode_stopping_tests(self, tab): + """Tests stopping a chat""" self.server_is_stopped(tab) self.web_server_is_stopped(tab) self.server_status_indicator_says_closed(tab) @@ -71,5 +72,23 @@ class TestChat(GuiBaseTest): Test chat mode """ tab = self.new_chat_tab() - self.run_all_chat_mode_tests(tab) + self.run_all_chat_mode_started_tests(tab) + self.view_chat(tab) + self.change_username(tab) + self.run_all_chat_mode_stopping_tests(tab) + self.close_all_tabs() + + + def test_405_page_returned_for_invalid_methods(self): + """ + Our custom 405 page should return for invalid methods + """ + tab = self.new_chat_tab() + + tab.get_mode().mode_settings_widget.public_checkbox.click() + + self.run_all_chat_mode_started_tests(tab) + url = f"http://127.0.0.1:{tab.app.port}/" + self.hit_405(url, expected_resp="OnionShare: 405 Method Not Allowed", data = {'foo':'bar'}, methods = ["put", "post", "delete", "options"]) + self.run_all_chat_mode_stopping_tests(tab) self.close_all_tabs() |