summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMicah Lee <micah@micahflee.com>2019-04-22 11:35:17 -0700
committerMicah Lee <micah@micahflee.com>2019-04-22 11:35:17 -0700
commit8be5e844c12b8ff60dd7afeea5b67564383695d6 (patch)
tree73cd79759b463cebd687ca509ed2cb7f6f31e95a
parentf3f458da8527969a251599054060c8f638375d5a (diff)
downloadonionshare-8be5e844c12b8ff60dd7afeea5b67564383695d6.tar.gz
onionshare-8be5e844c12b8ff60dd7afeea5b67564383695d6.zip
Fix typo in macOS notarize section of BUILD.md, and add note that it isn't ready yet
-rw-r--r--BUILD.md6
1 files changed, 5 insertions, 1 deletions
diff --git a/BUILD.md b/BUILD.md
index bf6200c0..abb03d74 100644
--- a/BUILD.md
+++ b/BUILD.md
@@ -339,8 +339,12 @@ To make a macOS release, go to macOS build machine:
Then move back to the developer machine:
+- PGP-sign the macOS installer, `gpg --detach-sign OnionShare-[version].pkg`
+
+Note that once we support notarizing the macOS installer (see [this issue](https://github.com/micahflee/onionshare/issues/953)), these will be the steps instead:
+
- Developer machine, running the latest macOS, must have an app-specific Apple ID password saved in the login keychain called `onionshare-notarize`
-- Notarize it: `crun altool --notarize-app --primary-bundle-id "com.micahflee.onionshare" -u "micah@micahflee.com" -p "@keychain:onionshare-notarize" --file OnionShare-[version].pkg`
+- Notarize it: `xcrun altool --notarize-app --primary-bundle-id "com.micahflee.onionshare" -u "micah@micahflee.com" -p "@keychain:onionshare-notarize" --file OnionShare-[version].pkg`
- Wait for it to get approved, check status with: `xcrun altool --notarization-history 0 -u "micah@micahflee.com" -p "@keychain:onionshare-notarize"`
- After it's approved, staple the ticket: `xcrun stapler staple OnionShare-[version].pkg`
- PGP-sign the final, notarized and stapled, `gpg --detach-sign OnionShare-[version].pkg`