fix: prevent gaps inside floating split containers (#5276)

Fixes https://github.com/i3/i3/issues/5272

2 files changed, 9 insertions, 1 deletions

diff --git a/src/con.c b/src/con.c
index 5bf559a1..5ecc2700 100644
--- a/src/con.c
+++ b/src/con.c
@@ -618,7 +618,10 @@ bool con_is_docked(Con *con) {
  *
  */
 Con *con_inside_floating(Con *con) {
-    assert(con != NULL);
+    if (con == NULL) {
+        return NULL;
+    }
+
     if (con->type == CT_FLOATING_CON)
         return con;
 
diff --git a/src/gaps.c b/src/gaps.c
index 545c8b65..a67e8ceb 100644
--- a/src/gaps.c
+++ b/src/gaps.c
@@ -52,6 +52,11 @@ bool gaps_should_inset_con(Con *con, int children) {
         return false;
     }
 
+    /* Floating split containers should never have gaps inside them. */
+    if (con_inside_floating(con)) {
+        return false;
+    }
+
     const bool leaf_or_stacked_tabbed =
         con_is_leaf(con) ||
         (con->layout == L_STACKED || con->layout == L_TABBED);