diff options
| author | Keith Randall <khr@golang.org> | 2023-09-18 13:31:49 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2023-10-06 17:02:53 +0000 |
| commit | cbcf8efa5f749b4e5bceda8682070cd9cf84bee5 (patch) | |
| tree | 0e8f56257343458b5ee320a146f27ed001d9fbf8 /test | |
| parent | b455e239aeeeb1d33eaa34e62c397f3408245a0c (diff) | |
| download | go-cbcf8efa5f749b4e5bceda8682070cd9cf84bee5.tar.gz go-cbcf8efa5f749b4e5bceda8682070cd9cf84bee5.zip | |
cmd/compile: use cache in front of type assert runtime call
That way we don't need to call into the runtime for every
type assertion (to an interface type).
name old time/op new time/op delta
TypeAssert-24 3.78ns ± 3% 1.00ns ± 1% -73.53% (p=0.000 n=10+8)
Change-Id: I0ba308aaf0f24a5495b4e13c814d35af0c58bfde
Reviewed-on: https://go-review.googlesource.com/c/go/+/529316
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/codegen/ifaces.go | 14 | ||||
| -rw-r--r-- | test/codegen/switch.go | 9 |
2 files changed, 19 insertions, 4 deletions
diff --git a/test/codegen/ifaces.go b/test/codegen/ifaces.go index d773845e8e..2be3fa5146 100644 --- a/test/codegen/ifaces.go +++ b/test/codegen/ifaces.go @@ -6,16 +6,22 @@ package codegen -type I interface { M() } +type I interface{ M() } func NopConvertIface(x I) I { - // amd64:-`.*runtime.convI2I` + // amd64:-`.*runtime.convI2I` return I(x) } func NopConvertGeneric[T any](x T) T { - // amd64:-`.*runtime.convI2I` - return T(x) + // amd64:-`.*runtime.convI2I` + return T(x) } var NopConvertGenericIface = NopConvertGeneric[I] + +func ConvToM(x any) I { + // amd64:`CALL\truntime.typeAssert`,`MOVL\t16\(.*\)`,`MOVQ\t8\(.*\)(.*\*1)` + // arm64:`CALL\truntime.typeAssert`,`LDAR`,`MOVWU`,`MOVD\t\(R.*\)\(R.*\)` + return x.(I) +} diff --git a/test/codegen/switch.go b/test/codegen/switch.go index 6778c65ab3..b0186ba5b7 100644 --- a/test/codegen/switch.go +++ b/test/codegen/switch.go @@ -139,3 +139,12 @@ func interfaceSwitch(x any) int { return 3 } } + +func interfaceCast(x any) int { + // amd64:`CALL\truntime.typeAssert`,`MOVL\t16\(.*\)`,`MOVQ\t8\(.*\)(.*\*1)` + // arm64:`CALL\truntime.typeAssert`,`LDAR`,`MOVWU`,`MOVD\t\(R.*\)\(R.*\)` + if _, ok := x.(I); ok { + return 3 + } + return 5 +} |