diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2021-06-24 09:07:52 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2021-06-24 18:24:24 +0000 |
| commit | df00abc61b415eb05d4df9fd2bf3fdda1aaaaba3 (patch) | |
| tree | e14f08c8088d5a8dc1849031e79c8dc180e7d7f3 /test/uintptrescapes2.go | |
| parent | b55cc6687d8f805663e9e803ad5293d1b399ce37 (diff) | |
| download | go-df00abc61b415eb05d4df9fd2bf3fdda1aaaaba3.tar.gz go-df00abc61b415eb05d4df9fd2bf3fdda1aaaaba3.zip | |
[dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers
This CL changes escape analysis to skip reporting diagnostics (at
least for parameter tagging) for generated wrappers.
We're inconsistent about when/where wrappers are generated, which made
errorcheck tests of escape analysis unnecessarily brittle to changes
in wrapper generation. This CL addresses this making errorcheck tests
only care about tagging of the actual functions themselves, not the
wrappers too.
Change-Id: Ia1a0b9dabee4d4162b05647f871db03b032c945a
Reviewed-on: https://go-review.googlesource.com/c/go/+/330689
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'test/uintptrescapes2.go')
| -rw-r--r-- | test/uintptrescapes2.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/uintptrescapes2.go b/test/uintptrescapes2.go index 3ff1d94042..656286c0ff 100644 --- a/test/uintptrescapes2.go +++ b/test/uintptrescapes2.go @@ -30,7 +30,7 @@ type T struct{} func (T) M1(a uintptr) {} // ERROR "escaping uintptr" //go:uintptrescapes -func (T) M2(a ...uintptr) {} // ERROR "escaping ...uintptr" "leaking param: a" +func (T) M2(a ...uintptr) {} // ERROR "escaping ...uintptr" func TestF1() { var t int // ERROR "moved to heap" |