diff options
| author | Alberto Donizetti <alb.donizetti@gmail.com> | 2017-04-22 15:28:58 +0200 |
|---|---|---|
| committer | Alberto Donizetti <alb.donizetti@gmail.com> | 2017-04-24 12:37:49 +0000 |
| commit | 1737aef270a8954f3f8718beb55d6ddfc1cf5d21 (patch) | |
| tree | 6173eb7a020ea88e61613caa2586236cdb1ec8de /test/shift1.go | |
| parent | 26536b2f327781ad76afe22109b94b7b193407bf (diff) | |
| download | go-1737aef270a8954f3f8718beb55d6ddfc1cf5d21.tar.gz go-1737aef270a8954f3f8718beb55d6ddfc1cf5d21.zip | |
cmd/compile: more error position tests for the typechecker
This change adds line position tests for several yyerror calls in the
typechecker that are currently not tested in any way.
Untested yyerror calls were found by replacing them with
yerrorl(src.NoXPos, ...)
(thus destroying position information in the error), and then running
the test suite. No failures means no test coverage for the relevant
yyerror call.
For #19683
Change-Id: Iedb3d2f02141b332e9bfa76dbf5ae930ad2fddc3
Reviewed-on: https://go-review.googlesource.com/41477
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'test/shift1.go')
| -rw-r--r-- | test/shift1.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/test/shift1.go b/test/shift1.go index aeefbc4517..c81ee5154d 100644 --- a/test/shift1.go +++ b/test/shift1.go @@ -68,6 +68,12 @@ func _() { w int64 = 1.0 << 33 // 1.0<<33 is a constant shift expression _, _, _, _, _, _, _, _, _, _ = j, k, m, n, o, u, u1, u2, v, w ) + + // non constants arguments trigger a different path + f2 := 1.2 + s2 := "hi" + _ = f2 << 2 // ERROR "shift of type float64" + _ = s2 << 2 // ERROR "shift of type string" } // shifts in comparisons w/ untyped operands |