diff options
author | Russ Cox <rsc@golang.org> | 2014-06-02 21:26:32 -0400 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2014-06-02 21:26:32 -0400 |
commit | eb54079264896a8e7bd0ea79768ea4f46c47e30a (patch) | |
tree | 57693750f65e944eae65515d0a84106e06b96b45 /test/live2.go | |
parent | d646040fd13b79f811c85bc7280a71c3493419ec (diff) | |
download | go-eb54079264896a8e7bd0ea79768ea4f46c47e30a.tar.gz go-eb54079264896a8e7bd0ea79768ea4f46c47e30a.zip |
cmd/gc: fix liveness for address-taken variables in inlined functions
The 'address taken' bit in a function variable was not
propagating into the inlined copies, causing incorrect
liveness information.
LGTM=dsymonds, bradfitz
R=golang-codereviews, bradfitz
CC=dsymonds, golang-codereviews, iant, khr, r
https://golang.org/cl/96670046
Diffstat (limited to 'test/live2.go')
-rw-r--r-- | test/live2.go | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/test/live2.go b/test/live2.go new file mode 100644 index 0000000000..1e32794026 --- /dev/null +++ b/test/live2.go @@ -0,0 +1,39 @@ +// errorcheck -0 -live + +// Copyright 2014 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// liveness tests with inlining ENABLED +// see also live.go. + +package main + +// issue 8142: lost 'addrtaken' bit on inlined variables. +// no inlining in this test, so just checking that non-inlined works. + +type T40 struct { + m map[int]int +} + +func newT40() *T40 { + ret := T40{ // ERROR "live at call to makemap: &ret" + make(map[int]int), + } + return &ret +} + +func bad40() { + t := newT40() // ERROR "live at call to makemap: ret" + println() // ERROR "live at call to printnl: ret" + _ = t +} + +func good40() { + ret := T40{ // ERROR "live at call to makemap: ret" + make(map[int]int), + } + t := &ret + println() // ERROR "live at call to printnl: ret" + _ = t +} |