diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2019-09-12 10:18:03 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2019-09-16 15:30:51 +0000 |
| commit | 606019cb4b1c8fb57e5a83747ee0aff1054291d8 (patch) | |
| tree | 04ff2c4bbf57c97d339663d2d46999702983121d /test/linkname.dir | |
| parent | 4ae25ff1405f9d6b25f40141f42196e8f142f207 (diff) | |
| download | go-606019cb4b1c8fb57e5a83747ee0aff1054291d8.tar.gz go-606019cb4b1c8fb57e5a83747ee0aff1054291d8.zip | |
cmd/compile: trim function name prefix from escape diagnostics
This information is redundant with the position information already
provided. Also, no other -m diagnostics print out function name.
While here, report parameter leak diagnostics against the parameter
declaration position rather than the function, and use Warnl for
"moved to heap" messages.
Test cases updated programmatically by removing the first word from
every "no match for" error emitted by run.go:
go run run.go |& \
sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \
while IFS='!' read -r fn line before after; do
before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g')
after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g')
fn=$(find . -name "${fn}" | head -1)
sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}"
done
Passes toolstash-check.
Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/195040
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/linkname.dir')
| -rw-r--r-- | test/linkname.dir/linkname1.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/linkname.dir/linkname1.go b/test/linkname.dir/linkname1.go index 9c61522fcc..c61a0d7d95 100644 --- a/test/linkname.dir/linkname1.go +++ b/test/linkname.dir/linkname1.go @@ -1,6 +1,6 @@ package x -func indexByte(xs []byte, b byte) int { // ERROR "indexByte xs does not escape" +func indexByte(xs []byte, b byte) int { // ERROR "xs does not escape" for i, x := range xs { if x == b { return i |