diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2019-09-12 10:18:03 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2019-09-16 15:30:51 +0000 |
| commit | 606019cb4b1c8fb57e5a83747ee0aff1054291d8 (patch) | |
| tree | 04ff2c4bbf57c97d339663d2d46999702983121d /test/inline_big.go | |
| parent | 4ae25ff1405f9d6b25f40141f42196e8f142f207 (diff) | |
| download | go-606019cb4b1c8fb57e5a83747ee0aff1054291d8.tar.gz go-606019cb4b1c8fb57e5a83747ee0aff1054291d8.zip | |
cmd/compile: trim function name prefix from escape diagnostics
This information is redundant with the position information already
provided. Also, no other -m diagnostics print out function name.
While here, report parameter leak diagnostics against the parameter
declaration position rather than the function, and use Warnl for
"moved to heap" messages.
Test cases updated programmatically by removing the first word from
every "no match for" error emitted by run.go:
go run run.go |& \
sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \
while IFS='!' read -r fn line before after; do
before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g')
after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g')
fn=$(find . -name "${fn}" | head -1)
sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}"
done
Passes toolstash-check.
Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/195040
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/inline_big.go')
| -rw-r--r-- | test/inline_big.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/inline_big.go b/test/inline_big.go index c4af15b4e1..b72ceb7f42 100644 --- a/test/inline_big.go +++ b/test/inline_big.go @@ -9,18 +9,18 @@ package foo -func small(a []int) int { // ERROR "can inline small as:.*" "small a does not escape" +func small(a []int) int { // ERROR "can inline small as:.*" "a does not escape" // Cost 16 body (need cost < 20). // See cmd/compile/internal/gc/inl.go:inlineBigFunction* return a[0] + a[1] + a[2] + a[3] } -func medium(a []int) int { // ERROR "can inline medium as:.*" "medium a does not escape" +func medium(a []int) int { // ERROR "can inline medium as:.*" "a does not escape" // Cost 32 body (need cost > 20 and cost < 80). // See cmd/compile/internal/gc/inl.go:inlineBigFunction* return a[0] + a[1] + a[2] + a[3] + a[4] + a[5] + a[6] + a[7] } -func f(a []int) int { // ERROR "cannot inline f:.*" "f a does not escape" +func f(a []int) int { // ERROR "cannot inline f:.*" "a does not escape" // Add lots of nodes to f's body. We need >5000. // See cmd/compile/internal/gc/inl.go:inlineBigFunction* a[0] = 0 |