diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2019-08-30 10:56:30 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2019-09-03 17:52:06 +0000 |
| commit | 9f89edcd9668bb3b011961fbcdd8fc2796acba5d (patch) | |
| tree | fac2ea3d67038eff5b913af5cb6b24224c94767f /test/escape_level.go | |
| parent | a71967e4c5aa34f274b8b9aff915f14ac00e7ee8 (diff) | |
| download | go-9f89edcd9668bb3b011961fbcdd8fc2796acba5d.tar.gz go-9f89edcd9668bb3b011961fbcdd8fc2796acba5d.zip | |
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/escape_level.go')
| -rw-r--r-- | test/escape_level.go | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/test/escape_level.go b/test/escape_level.go index 44a23e5a4d..33ae540532 100644 --- a/test/escape_level.go +++ b/test/escape_level.go @@ -15,7 +15,7 @@ func level0() { p0 := &i // ERROR "moved to heap: p0" p1 := &p0 // ERROR "moved to heap: p1" p2 := &p1 // ERROR "moved to heap: p2" - sink = &p2 // ERROR "&p2 escapes to heap" + sink = &p2 } func level1() { @@ -23,7 +23,7 @@ func level1() { p0 := &i // ERROR "moved to heap: p0" p1 := &p0 // ERROR "moved to heap: p1" p2 := &p1 - sink = p2 // ERROR "p2 escapes to heap" + sink = p2 } func level2() { @@ -31,7 +31,7 @@ func level2() { p0 := &i // ERROR "moved to heap: p0" p1 := &p0 p2 := &p1 - sink = *p2 // ERROR "\*p2 escapes to heap" + sink = *p2 } func level3() { @@ -39,7 +39,7 @@ func level3() { p0 := &i p1 := &p0 p2 := &p1 - sink = **p2 // ERROR "\* \(\*p2\) escapes to heap" + sink = **p2 } func level4() { @@ -47,7 +47,7 @@ func level4() { p0 := &i // ERROR "moved to heap: p0" p1 := &p0 p2 := p1 // ERROR "moved to heap: p2" - sink = &p2 // ERROR "&p2 escapes to heap" + sink = &p2 } func level5() { @@ -55,7 +55,7 @@ func level5() { p0 := &i // ERROR "moved to heap: p0" p1 := &p0 p2 := p1 - sink = p2 // ERROR "p2 escapes to heap" + sink = p2 } func level6() { @@ -63,7 +63,7 @@ func level6() { p0 := &i p1 := &p0 p2 := p1 - sink = *p2 // ERROR "\*p2 escapes to heap" + sink = *p2 } func level7() { @@ -72,7 +72,7 @@ func level7() { p1 := &p0 // note *p1 == &i p2 := *p1 // ERROR "moved to heap: p2" - sink = &p2 // ERROR "&p2 escapes to heap" + sink = &p2 } func level8() { @@ -80,7 +80,7 @@ func level8() { p0 := &i p1 := &p0 p2 := *p1 - sink = p2 // ERROR "p2 escapes to heap" + sink = p2 } func level9() { @@ -104,5 +104,5 @@ func level11() { p0 := &i p1 := &p0 p2 := **p1 // ERROR "moved to heap: p2" - sink = &p2 // ERROR "&p2 escapes to heap" + sink = &p2 } |