diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-01-07 16:35:31 -0500 |
|---|---|---|
| committer | Bryan Mills <bcmills@google.com> | 2022-01-10 17:06:19 +0000 |
| commit | 9e7ea3566e662ba498d64cb63146575202a053ee (patch) | |
| tree | 294b8ed205dbb3f94e37c68c13f753a79d9d5a4a /src | |
| parent | 931e84af4055dbcf91e986601d99e00c57136330 (diff) | |
| download | go-9e7ea3566e662ba498d64cb63146575202a053ee.tar.gz go-9e7ea3566e662ba498d64cb63146575202a053ee.zip | |
runtime: expand TestGdbPythonCgo skip to include mips64le
The failure mode in #37794 does not match the failure mode described
in #18784. However, since the test is currently skipped on all other
MIPS variants, it may be that they suffer from the same underlying GDB
bug. Ideally one of the Go MIPS maintainers should file an upstream
bug and remove the skip once it is fixed; in the meantime, there is no
point in continuing to let the test fail on just one of the four MIPS
variants.
For #37794
Change-Id: I570f51cc04cbb7ef1ed7efd526e26886af53bfb6
Reviewed-on: https://go-review.googlesource.com/c/go/+/376654
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/runtime/runtime-gdb_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 63d3160ee4..7e8723e15f 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -153,8 +153,8 @@ func TestGdbPython(t *testing.T) { } func TestGdbPythonCgo(t *testing.T) { - if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" || runtime.GOARCH == "mips64" { - testenv.SkipFlaky(t, 18784) + if strings.HasPrefix(runtime.GOARCH, "mips") { + testenv.SkipFlaky(t, 37794) } testGdbPython(t, true) } |