diff options
author | Kir Kolyshkin <kolyshkin@gmail.com> | 2024-05-25 23:08:37 -0700 |
---|---|---|
committer | Gopher Robot <gobot@golang.org> | 2024-05-30 00:12:19 +0000 |
commit | 9488a444d9c752f4e1da19907945c4cc740a6c14 (patch) | |
tree | 93e91e1c2d67516fb40fc03db60db87d49697d77 /src/vendor/modules.txt | |
parent | c8e40338cf00f3c1d86c8fb23863ad67a4c72bcc (diff) | |
download | go-release-branch.go1.21.tar.gz go-release-branch.go1.21.zip |
[release-branch.go1.21] os: RemoveAll: fix symlink race for unixrelease-branch.go1.21
Since all the platforms now support O_DIRECTORY flag for open, it can be
used to (together with O_NOFOLLOW) to ensure we open a directory, thus
eliminating the need to call stat before open. This fixes the symlink race,
when a directory is replaced by a symlink in between stat and open calls.
While at it, rename openFdAt to openDirAt, because this function is (and was)
meant for directories only.
NOTE Solaris supports O_DIRECTORY since before Solaris 11 (which is the
only version Go supports since supported version now), and Illumos
always had it. The only missing piece was O_DIRECTORY flag value, which
is taken from golang.org/x/sys/unix.
Fixes #67695.
Change-Id: Ic1111d688eebc8804a87d39d3261c2a6eb33f176
Reviewed-on: https://go-review.googlesource.com/c/go/+/589057
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Diffstat (limited to 'src/vendor/modules.txt')
0 files changed, 0 insertions, 0 deletions