diff options
author | Austin Clements <austin@google.com> | 2023-04-24 14:26:39 -0400 |
---|---|---|
committer | Austin Clements <austin@google.com> | 2023-04-25 19:49:28 +0000 |
commit | ce0b9143123abe8005a059c92dbd763f7ab46214 (patch) | |
tree | 65a1510010fb7d70517017ac3a2226a4751906d9 /src/testing | |
parent | 715d53c090ea02dbd73c301684ecbd09b476989e (diff) | |
download | go-ce0b9143123abe8005a059c92dbd763f7ab46214.tar.gz go-ce0b9143123abe8005a059c92dbd763f7ab46214.zip |
cmd/dist: actually only compile tests with -compile-only
Currently, "dist test -compile-only" still runs the test binaries,
just with -run=^$ so no tests are run. It does this because, until
recently, "go test -c" would fail if passed multiple test packages.
But this has some unexpected consequences: init code still runs,
TestMain still runs, and we generally can't test cross-compiling of
tests.
Now that #15513 is fixed, we can pass multiple packages to "go test
-c". Hence, this CL make dist just use "go test -c" as one would
expect.
Found in the course of working on #37486, though it doesn't really
affect that.
Change-Id: If7d3c72c9e0f74d4ea0dd422411e5ee93b314be4
Reviewed-on: https://go-review.googlesource.com/c/go/+/488275
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Austin Clements <austin@google.com>
Diffstat (limited to 'src/testing')
-rw-r--r-- | src/testing/testing.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/testing/testing.go b/src/testing/testing.go index c970d05256..fcf7048f23 100644 --- a/src/testing/testing.go +++ b/src/testing/testing.go @@ -1934,7 +1934,6 @@ func (m *M) Run() (code int) { // in which case every test will run nothing and succeed, // with no obvious way to detect this problem (since no tests are running). // So make 'no tests to run' a hard failure when testing package testing itself. - // The compile-only builders use -run=^$ to run no tests, so allow that. fmt.Print(chatty.prefix(), "FAIL: package testing must run tests\n") testOk = false } |