diff options
| author | Than McIntosh <thanm@google.com> | 2024-05-09 20:02:30 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-09 20:33:37 +0000 |
| commit | 9eebdca8a94d3d47f4973371abf1bc10c626892d (patch) | |
| tree | 946e8838d9619403083c5cade79c83ddd4cf1ca3 /src/runtime | |
| parent | e2375c49ff837a506855ce26ec160f21dc744b88 (diff) | |
| download | go-9eebdca8a94d3d47f4973371abf1bc10c626892d.tar.gz go-9eebdca8a94d3d47f4973371abf1bc10c626892d.zip | |
runtime: add workaround to "throw" pending resolution of issue #67274
Temporarily mark the function runtime.throw as "go:noinline" for the
time being to work around problems introduced by CL 581215. We do not
ordinarily inline runtime.throw unless the build is beind done with an
elevated inline budget (e.g. "-gcflags=-l=4"), so this change should
only have an effect for those special builds.
Updates #67274.
Change-Id: I3811913b8d441e0ddb1d4c7d7297ef23555582a2
Reviewed-on: https://go-review.googlesource.com/c/go/+/584616
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/panic.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/runtime/panic.go b/src/runtime/panic.go index 27fcf73ff4..122fc30df2 100644 --- a/src/runtime/panic.go +++ b/src/runtime/panic.go @@ -1010,7 +1010,11 @@ func sync_fatal(s string) { // throw should be used for runtime-internal fatal errors where Go itself, // rather than user code, may be at fault for the failure. // +// NOTE: temporarily marked "go:noinline" pending investigation/fix of +// issue #67274, so as to fix longtest builders. +// //go:nosplit +//go:noinline func throw(s string) { // Everything throw does should be recursively nosplit so it // can be called even when it's unsafe to grow the stack. |