diff options
| author | Ian Lance Taylor <iant@golang.org> | 2021-11-23 12:25:10 -0800 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2021-11-23 21:59:51 +0000 |
| commit | 1ac45e026b2cbae91e3495e2cc6e93b6d505b4f4 (patch) | |
| tree | e43fdb3bf0bf189744260a6a32ef65a07ca8fda8 /src/runtime | |
| parent | e3eaedb5cf623d0836533573db4140749da42768 (diff) | |
| download | go-1ac45e026b2cbae91e3495e2cc6e93b6d505b4f4.tar.gz go-1ac45e026b2cbae91e3495e2cc6e93b6d505b4f4.zip | |
runtime: run the right test in TestCgoExternalThreadSignal
The code was accidentally repeating the TestCgoExternalThreadSIGPROF test.
While we're here remove an obsolete skip on ppc64/linux.
Change-Id: Icdc4032a67aa80fbcfcd7c5c7ab8a6f23f321e2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/366755
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/crash_cgo_test.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 45ee6d6905..bfb260a143 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -94,11 +94,6 @@ func TestCgoExternalThreadSIGPROF(t *testing.T) { case "plan9", "windows": t.Skipf("no pthreads on %s", runtime.GOOS) } - if runtime.GOARCH == "ppc64" && runtime.GOOS == "linux" { - // TODO(austin) External linking not implemented on - // linux/ppc64 (issue #8912) - t.Skipf("no external linking on ppc64") - } exe, err := buildTestProg(t, "testprogcgo", "-tags=threadprof") if err != nil { @@ -128,7 +123,7 @@ func TestCgoExternalThreadSignal(t *testing.T) { t.Fatal(err) } - got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSIGPROF")).CombinedOutput() + got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSignal")).CombinedOutput() if err != nil { t.Fatalf("exit status: %v\n%s", err, got) } |