diff options
| author | Zhongwei Yao <zhongwei.yao@arm.com> | 2016-04-25 11:08:38 +0800 |
|---|---|---|
| committer | Michael Munday <munday@ca.ibm.com> | 2016-04-27 17:47:49 +0000 |
| commit | 74a9bad63899ffb02b747678c2c181ffb13983b9 (patch) | |
| tree | c932ed719c212346073b988d7d3e7be61900751c /src/runtime/vlrt.go | |
| parent | 7538b1db8ec0d82a623847fe5987f1988fe16448 (diff) | |
| download | go-74a9bad63899ffb02b747678c2c181ffb13983b9.tar.gz go-74a9bad63899ffb02b747678c2c181ffb13983b9.zip | |
cmd/compile: enable const division for arm64
performance:
benchmark old ns/op new ns/op delta
BenchmarkDivconstI64-8 8.28 2.70 -67.39%
BenchmarkDivconstU64-8 8.28 4.69 -43.36%
BenchmarkDivconstI32-8 8.28 6.39 -22.83%
BenchmarkDivconstU32-8 8.28 4.43 -46.50%
BenchmarkDivconstI16-8 5.17 5.17 +0.00%
BenchmarkDivconstU16-8 5.33 5.34 +0.19%
BenchmarkDivconstI8-8 3.50 3.50 +0.00%
BenchmarkDivconstU8-8 3.51 3.50 -0.28%
Fixes #15382
Change-Id: Ibce7b28f0586d593b33c4d4ecc5d5e7e7c905d13
Reviewed-on: https://go-review.googlesource.com/22292
Reviewed-by: Michael Munday <munday@ca.ibm.com>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'src/runtime/vlrt.go')
| -rw-r--r-- | src/runtime/vlrt.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/runtime/vlrt.go b/src/runtime/vlrt.go index 2419f78ce2..cd37828ae4 100644 --- a/src/runtime/vlrt.go +++ b/src/runtime/vlrt.go @@ -195,7 +195,6 @@ func dodiv(n, d uint64) (q, r uint64) { if GOARCH == "arm" { // arm doesn't have a division instruction, so // slowdodiv is the best that we can do. - // TODO: revisit for arm64. return slowdodiv(n, d) } |