diff options
| author | Michael Knyszek <mknyszek@google.com> | 2020-01-24 16:51:11 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2020-01-24 23:27:33 +0000 |
| commit | 64c22b70bf00e15615bb17c29f808b55bc339682 (patch) | |
| tree | 568f5948390be827a761e65928f048597ab5b7ad /src/runtime/trace | |
| parent | ad3cef184e55ab53306a466bda100dc72c40fc3b (diff) | |
| download | go-64c22b70bf00e15615bb17c29f808b55bc339682.tar.gz go-64c22b70bf00e15615bb17c29f808b55bc339682.zip | |
Revert "runtime: don't hold worldsema across mark phase"
This reverts commit 7b294cdd8df0a9523010f6ffc80c59e64578f34b, CL 182657.
Reason for revert: This change may be causing latency problems
for applications which call ReadMemStats, because it may cause
all goroutines to stop until the GC completes.
https://golang.org/cl/215157 fixes this problem, but it's too
late in the cycle to land that.
Updates #19812.
Change-Id: Iaa26f4dec9b06b9db2a771a44e45f58d0aa8f26d
Reviewed-on: https://go-review.googlesource.com/c/go/+/216358
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/runtime/trace')
| -rw-r--r-- | src/runtime/trace/trace_stack_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/runtime/trace/trace_stack_test.go b/src/runtime/trace/trace_stack_test.go index e3608c687f..62c06e67d9 100644 --- a/src/runtime/trace/trace_stack_test.go +++ b/src/runtime/trace/trace_stack_test.go @@ -233,7 +233,6 @@ func TestTraceSymbolize(t *testing.T) { }}, {trace.EvGomaxprocs, []frame{ {"runtime.startTheWorld", 0}, // this is when the current gomaxprocs is logged. - {"runtime.startTheWorldGC", 0}, {"runtime.GOMAXPROCS", 0}, {"runtime/trace_test.TestTraceSymbolize", 0}, {"testing.tRunner", 0}, |