diff options
| author | David du Colombier <0intro@gmail.com> | 2018-02-13 22:11:20 +0100 |
|---|---|---|
| committer | David du Colombier <0intro@gmail.com> | 2018-02-13 22:55:49 +0000 |
| commit | 5114a7daa2f128d2de82cddb29a076d2a8e4def8 (patch) | |
| tree | b30b6c671f6c9e204184685db04ca8981a802663 /src/runtime/trace | |
| parent | 8693b4f095b2efdbd11967655579606bc3192c59 (diff) | |
| download | go-5114a7daa2f128d2de82cddb29a076d2a8e4def8.tar.gz go-5114a7daa2f128d2de82cddb29a076d2a8e4def8.zip | |
runtime/trace: fix TestTraceSymbolize when GOMAXPROCS=1
CL 92916 added the GOMAXPROCS test in TestTraceSymbolize.
This test only succeeds when the value of GOMAXPROCS changes.
Since the test calls runtime.GOMAXPROCS(1), it will fails
on machines where GOMAXPROCS=1.
This change fixes the test by calling runtime.GOMAXPROCS(oldGoMaxProcs+1).
Fixes #23816.
Change-Id: I1183dbbd7db6077cbd7fa0754032ff32793b2195
Reviewed-on: https://go-review.googlesource.com/93735
Run-TryBot: David du Colombier <0intro@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/trace')
| -rw-r--r-- | src/runtime/trace/trace_stack_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/runtime/trace/trace_stack_test.go b/src/runtime/trace/trace_stack_test.go index 0275279a6b..e7b8d57659 100644 --- a/src/runtime/trace/trace_stack_test.go +++ b/src/runtime/trace/trace_stack_test.go @@ -128,7 +128,8 @@ func TestTraceSymbolize(t *testing.T) { wp.Write(data[:]) <-pipeReadDone - oldGoMaxProcs := runtime.GOMAXPROCS(1) + oldGoMaxProcs := runtime.GOMAXPROCS(0) + runtime.GOMAXPROCS(oldGoMaxProcs + 1) Stop() |