diff options
author | Alex Brainman <alex.brainman@gmail.com> | 2017-09-26 12:35:54 +1000 |
---|---|---|
committer | Alex Brainman <alex.brainman@gmail.com> | 2017-09-27 01:10:05 +0000 |
commit | 438c8f6b531a1cfcb4a084d3090b631938a9839e (patch) | |
tree | 7cd0ec8b7f95fe2e374d14f7f550c72e0c26edfc /src/runtime/syscall_windows.go | |
parent | 5e42658fc04c8f4ce15f3e2d75f4f5d045640738 (diff) | |
download | go-438c8f6b531a1cfcb4a084d3090b631938a9839e.tar.gz go-438c8f6b531a1cfcb4a084d3090b631938a9839e.zip |
syscall: make Exit call runtime.exit
syscall.Exit and runtime.exit do the same thing.
Why duplicate code?
CL 45115 fixed bug where windows runtime.exit was correct,
but syscall.Exit was broken. So CL 45115 fixed windows
syscall.Exit by calling runtime.exit.
Austin suggested that all OSes should do the same, and
this CL implements his idea.
While making changes, I discovered that nacl syscall.Exit
returned error
func Exit(code int) (err error)
and I changed it into
func Exit(code int)
like all other OSes. I assumed it was a mistake and it
is OK to do because cmd/api does not complain about it.
Also I changed plan9 runtime.exit to accept int32 just
like all other OSes do.
Change-Id: I12f6022ad81406566cf9befcc6edc382eebd413b
Reviewed-on: https://go-review.googlesource.com/66170
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: David du Colombier <0intro@gmail.com>
Diffstat (limited to 'src/runtime/syscall_windows.go')
-rw-r--r-- | src/runtime/syscall_windows.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/runtime/syscall_windows.go b/src/runtime/syscall_windows.go index f170bc3f8f..134d4dbd99 100644 --- a/src/runtime/syscall_windows.go +++ b/src/runtime/syscall_windows.go @@ -223,9 +223,3 @@ func syscall_Syscall15(fn, nargs, a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11, cgocall(asmstdcallAddr, unsafe.Pointer(c)) return c.r1, c.r2, c.err } - -//go:linkname syscall_exit syscall.Exit -//go:nosplit -func syscall_exit(code int) { - exit(int32(code)) -} |