diff options
| author | Austin Clements <austin@google.com> | 2018-01-31 14:34:36 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2018-01-31 20:57:53 +0000 |
| commit | e5186895fc7954c0992c345eb2a91f8c964b2099 (patch) | |
| tree | 4bd3cb0c4ab324365b37ae1acbdf6cc919cdafd8 /src/runtime/signal_linux_mips64x.go | |
| parent | 3ff41cdffade9e7b5a78fa56a43351dbd665df7a (diff) | |
| download | go-e5186895fc7954c0992c345eb2a91f8c964b2099.tar.gz go-e5186895fc7954c0992c345eb2a91f8c964b2099.zip | |
runtime: restore RSB for sigpanic call on mips64x
preparePanic must set all registers expected by Go runtime conventions
in case the sigpanic is being injected into C code. However, on
mips64x it fails to restore RSB (R28). As a result, if C code modifies
RSB and then raises a signal that turns into a sigpanic call, sigpanic
may crash when it attempts to lock runtime.debuglock (the first global
it references).
Fix this by restoring RSB in the signal context using the same
convention as main and sigtramp.
Fixes #23641.
Change-Id: Ib47e83df89e2a3eece10f480e4e91ce9e4424388
Reviewed-on: https://go-review.googlesource.com/91156
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/signal_linux_mips64x.go')
| -rw-r--r-- | src/runtime/signal_linux_mips64x.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/runtime/signal_linux_mips64x.go b/src/runtime/signal_linux_mips64x.go index 9e0cf42c70..b608197d60 100644 --- a/src/runtime/signal_linux_mips64x.go +++ b/src/runtime/signal_linux_mips64x.go @@ -66,6 +66,7 @@ func (c *sigctxt) hi() uint64 { return c.regs().sc_mdhi } func (c *sigctxt) sigcode() uint32 { return uint32(c.info.si_code) } func (c *sigctxt) sigaddr() uint64 { return c.info.si_addr } +func (c *sigctxt) set_r28(x uint64) { c.regs().sc_regs[28] = x } func (c *sigctxt) set_r30(x uint64) { c.regs().sc_regs[30] = x } func (c *sigctxt) set_pc(x uint64) { c.regs().sc_pc = x } func (c *sigctxt) set_sp(x uint64) { c.regs().sc_regs[29] = x } |