diff options
| author | Ou Changkun <hi@changkun.us> | 2019-08-16 13:50:07 +0000 |
|---|---|---|
| committer | Emmanuel Odeke <emm.odeke@gmail.com> | 2019-09-01 00:05:48 +0000 |
| commit | d6143914e42e9373fbc02d08b224516b12807269 (patch) | |
| tree | 41439bef8c68bdc0e7676fe0f383d372afcb9236 /src/runtime/select.go | |
| parent | b003afe4fea9427ea8d8014dd4be1b02124af520 (diff) | |
| download | go-d6143914e42e9373fbc02d08b224516b12807269.tar.gz go-d6143914e42e9373fbc02d08b224516b12807269.zip | |
runtime: remove outdated comment in select sortkey
This CL removes an outdated comment regarding converting a pointer to `uintptr`.
The comment was introduced in Go 1.4 and runtime GC was under the consideration of major revisions. According to the current situation, Go runtime memory allocator has no fragmentation issue. Therefore compact GC won't be implemented in the near future.
Change-Id: I5c336d81d810cf57b76797f05428421bb39a5b9f
GitHub-Last-Rev: 2ab4be3885d3f48abbcb59af3f74bc95501ff23f
GitHub-Pull-Request: golang/go#33685
Reviewed-on: https://go-review.googlesource.com/c/go/+/190520
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/select.go')
| -rw-r--r-- | src/runtime/select.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/runtime/select.go b/src/runtime/select.go index 86182890cc..d2c5a03a1a 100644 --- a/src/runtime/select.go +++ b/src/runtime/select.go @@ -493,8 +493,6 @@ sclose: } func (c *hchan) sortkey() uintptr { - // TODO(khr): if we have a moving garbage collector, we'll need to - // change this function. return uintptr(unsafe.Pointer(c)) } |