diff options
| author | Cherry Zhang <cherryyz@google.com> | 2016-10-27 14:33:58 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2016-10-28 20:17:53 +0000 |
| commit | 9d1efba28db4c045356c92c20f98cf12b5f31d72 (patch) | |
| tree | 39048e5b6b97910261c2517f32e9f9c82adf567f /src/runtime/runtime-lldb_test.go | |
| parent | c39918a04991387f14cab1204f54fafab81bc105 (diff) | |
| download | go-9d1efba28db4c045356c92c20f98cf12b5f31d72.tar.gz go-9d1efba28db4c045356c92c20f98cf12b5f31d72.zip | |
cmd/link: put text at address 0x1000000 on darwin/amd64
Apparently on macOS Sierra LLDB thinks /usr/lib/dyld is mapped
at address 0, even if Go code starts at 0x1000, and it looks up
addresses from dyld which shadows Go symbols. Move Go binary at
a higher address to avoid clash.
Fixes #17463. Re-enable TestLldbPython.
Change-Id: I89ca6f3ee48aa6da9862bfa0c2da91477cc93255
Reviewed-on: https://go-review.googlesource.com/32185
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Quentin Smith <quentin@golang.org>
Diffstat (limited to 'src/runtime/runtime-lldb_test.go')
| -rw-r--r-- | src/runtime/runtime-lldb_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/runtime/runtime-lldb_test.go b/src/runtime/runtime-lldb_test.go index f222ace1e3..98bc906666 100644 --- a/src/runtime/runtime-lldb_test.go +++ b/src/runtime/runtime-lldb_test.go @@ -139,7 +139,6 @@ intvar = 42 ` func TestLldbPython(t *testing.T) { - t.Skip("issue 17463") testenv.MustHaveGoBuild(t) if final := os.Getenv("GOROOT_FINAL"); final != "" && runtime.GOROOT() != final { t.Skip("gdb test can fail with GOROOT_FINAL pending") |