diff options
| author | Keith Randall <khr@golang.org> | 2017-05-31 08:45:10 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2017-08-15 01:52:23 +0000 |
| commit | 3d1699ea787f38be6088f9a098d6e08dafca9387 (patch) | |
| tree | a054a8dbebd936a9128e9505199f30f699dd4679 /src/runtime/plugin.go | |
| parent | e098e5142dd9554352171423f175381fd14fd943 (diff) | |
| download | go-3d1699ea787f38be6088f9a098d6e08dafca9387.tar.gz go-3d1699ea787f38be6088f9a098d6e08dafca9387.zip | |
runtime: new itab lookup table
Keep itabs in a growable hash table.
Use a simple open-addressable hash table, quadratic probing, power
of two sized.
Synchronization gets a bit more tricky. The common read path now
has two atomic reads, one to get the table pointer and one to read
the entry out of the table.
I set the max load factor to 75%, kind of arbitrarily. There's a
space-speed tradeoff here, and I'm not sure where we should land.
Because we use open addressing the itab.link field is no longer needed.
I'll remove it in a separate CL.
Fixes #20505
Change-Id: Ifb3d9a337512d6cf968c1fceb1eeaf89559afebf
Reviewed-on: https://go-review.googlesource.com/44472
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Diffstat (limited to 'src/runtime/plugin.go')
| -rw-r--r-- | src/runtime/plugin.go | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/runtime/plugin.go b/src/runtime/plugin.go index 682caacb21..34b306ae25 100644 --- a/src/runtime/plugin.go +++ b/src/runtime/plugin.go @@ -54,13 +54,11 @@ func plugin_lastmoduleinit() (path string, syms map[string]interface{}, mismatch pluginftabverify(md) moduledataverify1(md) - lock(&ifaceLock) + lock(&itabLock) for _, i := range md.itablinks { - if !i.inhash { - additab(i, true, false) - } + itabAddStartup(i) } - unlock(&ifaceLock) + unlock(&itabLock) // Build a map of symbol names to symbols. Here in the runtime // we fill out the first word of the interface, the type. We |