diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2019-12-19 17:44:58 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2019-12-26 21:16:03 +0000 |
| commit | cd1b9c1d5a7bb8ea6ebec223ce11e91897584ef4 (patch) | |
| tree | d5c6a79d2fd7b86a413fc36536a2797a74228f06 /src/runtime/mgcscavenge_test.go | |
| parent | 075c20cea8a1efda0e8d5d33a1995a220ad27b8c (diff) | |
| download | go-cd1b9c1d5a7bb8ea6ebec223ce11e91897584ef4.tar.gz go-cd1b9c1d5a7bb8ea6ebec223ce11e91897584ef4.zip | |
runtime: disable pageAlloc tests on OpenBSD in short mode
This change disables pageAlloc tests on OpenBSD in short mode because
pageAlloc holds relatively large virtual memory reservations and we make
two during the pageAlloc tests. The runtime may also be carrying one
such reservation making the virtual memory requirement for testing the
Go runtime three times as much as just running a Go binary.
This causes problems for folks who just want to build and test Go
(all.bash) on OpenBSD but either don't have machines with at least 4ish
GiB of RAM (per-process virtual memory limits are capped at some
constant factor times the amount of physical memory) or their
per-process virtual memory limits are low for other reasons.
Fixes #36210.
Change-Id: I8d89cfde448d4cd2fefff4ad6ffed90de63dd527
Reviewed-on: https://go-review.googlesource.com/c/go/+/212177
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/runtime/mgcscavenge_test.go')
| -rw-r--r-- | src/runtime/mgcscavenge_test.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/runtime/mgcscavenge_test.go b/src/runtime/mgcscavenge_test.go index 518d5ab27a..a6eba8d972 100644 --- a/src/runtime/mgcscavenge_test.go +++ b/src/runtime/mgcscavenge_test.go @@ -272,6 +272,9 @@ func TestPallocDataFindScavengeCandidate(t *testing.T) { // Tests end-to-end scavenging on a pageAlloc. func TestPageAllocScavenge(t *testing.T) { + if GOOS == "openbsd" && testing.Short() { + t.Skip("skipping because virtual memory is limited; see #36210") + } type test struct { request, expect uintptr } |