diff options
| author | Austin Clements <austin@google.com> | 2017-07-10 14:34:26 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2017-09-22 20:05:37 +0000 |
| commit | 4c02eaf77e2eae7d92d22216af040c04d6879fc6 (patch) | |
| tree | f93953337d0665afe807ac6f6d6cd9304380cfda /src/runtime/malloc_test.go | |
| parent | 6cac100eefbe07ffd2c9bf64c9a782bf93d79081 (diff) | |
| download | go-4c02eaf77e2eae7d92d22216af040c04d6879fc6.tar.gz go-4c02eaf77e2eae7d92d22216af040c04d6879fc6.zip | |
runtime: re-add sanity check for GCCPUFraction
This no longer appears to be reproducible on windows/386. Try putting
it back and we'll see if the builders still don't like it.
Fixes #19319.
Change-Id: Ia47b034e18d0a5a1951125c00542b021aacd5e8d
Reviewed-on: https://go-review.googlesource.com/47936
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/runtime/malloc_test.go')
| -rw-r--r-- | src/runtime/malloc_test.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/runtime/malloc_test.go b/src/runtime/malloc_test.go index d9487eed3a..93aa56dbd5 100644 --- a/src/runtime/malloc_test.go +++ b/src/runtime/malloc_test.go @@ -46,9 +46,6 @@ func TestMemStats(t *testing.T) { } // Of the uint fields, HeapReleased, HeapIdle can be 0. // PauseTotalNs can be 0 if timer resolution is poor. - // - // TODO: Test that GCCPUFraction is <= 0.99. This currently - // fails on windows/386. (Issue #19319) fields := map[string][]func(interface{}) error{ "Alloc": {nz, le(1e10)}, "TotalAlloc": {nz, le(1e11)}, "Sys": {nz, le(1e10)}, "Lookups": {nz, le(1e10)}, "Mallocs": {nz, le(1e10)}, "Frees": {nz, le(1e10)}, @@ -61,7 +58,7 @@ func TestMemStats(t *testing.T) { "NextGC": {nz, le(1e10)}, "LastGC": {nz}, "PauseTotalNs": {le(1e11)}, "PauseNs": nil, "PauseEnd": nil, "NumGC": {nz, le(1e9)}, "NumForcedGC": {nz, le(1e9)}, - "GCCPUFraction": nil, "EnableGC": {eq(true)}, "DebugGC": {eq(false)}, + "GCCPUFraction": {le(0.99)}, "EnableGC": {eq(true)}, "DebugGC": {eq(false)}, "BySize": nil, } |