diff options
| author | Keith Randall <khr@google.com> | 2018-03-01 16:38:41 -0800 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2018-03-02 22:46:15 +0000 |
| commit | 403ab0f2214f583db84a2dae275389be92072a35 (patch) | |
| tree | 9ff2fc82235a27acd95595f2152f03eec83fa71e /src/runtime/asm_mips64x.s | |
| parent | dcedcaa5fb15748cc2e5cb9461fc6b4f4fc942cb (diff) | |
| download | go-403ab0f2214f583db84a2dae275389be92072a35.tar.gz go-403ab0f2214f583db84a2dae275389be92072a35.zip | |
internal/bytealg: move IndexByte asssembly to the new bytealg package
Move the IndexByte function from the runtime to a new bytealg package.
The new package will eventually hold all the optimized assembly for
groveling through byte slices and strings. It seems a better home for
this code than randomly keeping it in runtime.
Once this is in, the next step is to move the other functions
(Compare, Equal, ...).
Update #19792
This change seems complicated enough that we might just declare
"not worth it" and abandon. Opinions welcome.
The core assembly is all unchanged, except minor modifications where
the code reads cpu feature bits.
The wrapper functions have been cleaned up as they are now actually
checked by vet.
Change-Id: I9fa75bee5d85db3a65b3fd3b7997e60367523796
Reviewed-on: https://go-review.googlesource.com/98016
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/runtime/asm_mips64x.s')
| -rw-r--r-- | src/runtime/asm_mips64x.s | 46 |
1 files changed, 0 insertions, 46 deletions
diff --git a/src/runtime/asm_mips64x.s b/src/runtime/asm_mips64x.s index f59421fbf6..ca47824ab8 100644 --- a/src/runtime/asm_mips64x.s +++ b/src/runtime/asm_mips64x.s @@ -697,52 +697,6 @@ equal: MOVB R1, ret+48(FP) RET -TEXT bytes·IndexByte(SB),NOSPLIT,$0-40 - MOVV s+0(FP), R1 - MOVV s_len+8(FP), R2 - MOVBU c+24(FP), R3 // byte to find - MOVV R1, R4 // store base for later - ADDV R1, R2 // end - ADDV $-1, R1 - -loop: - ADDV $1, R1 - BEQ R1, R2, notfound - MOVBU (R1), R5 - BNE R3, R5, loop - - SUBV R4, R1 // remove base - MOVV R1, ret+32(FP) - RET - -notfound: - MOVV $-1, R1 - MOVV R1, ret+32(FP) - RET - -TEXT strings·IndexByte(SB),NOSPLIT,$0-32 - MOVV p+0(FP), R1 - MOVV b_len+8(FP), R2 - MOVBU c+16(FP), R3 // byte to find - MOVV R1, R4 // store base for later - ADDV R1, R2 // end - ADDV $-1, R1 - -loop: - ADDV $1, R1 - BEQ R1, R2, notfound - MOVBU (R1), R5 - BNE R3, R5, loop - - SUBV R4, R1 // remove base - MOVV R1, ret+24(FP) - RET - -notfound: - MOVV $-1, R1 - MOVV R1, ret+24(FP) - RET - TEXT runtime·return0(SB), NOSPLIT, $0 MOVW $0, R1 RET |