diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2021-01-28 15:23:05 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2021-04-02 16:53:18 +0000 |
| commit | 28c5fed5576483cc696db233d7f6fffecd2833a2 (patch) | |
| tree | 00109d3e508e63bbfff7c5c73f2b54ea321c402c /src/runtime/asm_amd64.s | |
| parent | 6996bae5d1d34ea9e2ab6399f70adb402697ed94 (diff) | |
| download | go-28c5fed5576483cc696db233d7f6fffecd2833a2.tar.gz go-28c5fed5576483cc696db233d7f6fffecd2833a2.zip | |
reflect: add register ABI support for makeFuncStub and methodValueCall
This change finishes off functionality register ABI for the reflect
package.
Specifically, it implements a call on a MakeFunc'd value by performing
the reverse process that reflect.Value.Call does, using the same ABI
steps. It implements a call on a method value created by reflect by
translating between the method value's ABI to the method's ABI.
Tests are added for both cases.
For #40724.
Change-Id: I302820b61fc0a8f94c5525a002bc02776aef41af
Reviewed-on: https://go-review.googlesource.com/c/go/+/298670
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/runtime/asm_amd64.s')
| -rw-r--r-- | src/runtime/asm_amd64.s | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s index 193d8f00bb..dbe7f7f381 100644 --- a/src/runtime/asm_amd64.s +++ b/src/runtime/asm_amd64.s @@ -473,7 +473,7 @@ TEXT runtime·morestack_noctxt(SB),NOSPLIT,$0 #ifdef GOEXPERIMENT_REGABI_REFLECT // spillArgs stores return values from registers to a *internal/abi.RegArgs in R12. -TEXT spillArgs<>(SB),NOSPLIT,$0-0 +TEXT ·spillArgs<ABIInternal>(SB),NOSPLIT,$0-0 MOVQ AX, 0(R12) MOVQ BX, 8(R12) MOVQ CX, 16(R12) @@ -501,7 +501,7 @@ TEXT spillArgs<>(SB),NOSPLIT,$0-0 RET // unspillArgs loads args into registers from a *internal/abi.RegArgs in R12. -TEXT unspillArgs<>(SB),NOSPLIT,$0-0 +TEXT ·unspillArgs<ABIInternal>(SB),NOSPLIT,$0-0 MOVQ 0(R12), AX MOVQ 8(R12), BX MOVQ 16(R12), CX @@ -529,11 +529,11 @@ TEXT unspillArgs<>(SB),NOSPLIT,$0-0 RET #else // spillArgs stores return values from registers to a pointer in R12. -TEXT spillArgs<>(SB),NOSPLIT,$0-0 +TEXT ·spillArgs<ABIInternal>(SB),NOSPLIT,$0-0 RET // unspillArgs loads args into registers from a pointer in R12. -TEXT unspillArgs<>(SB),NOSPLIT,$0-0 +TEXT ·unspillArgs<ABIInternal>(SB),NOSPLIT,$0-0 RET #endif @@ -592,7 +592,7 @@ TEXT NAME(SB), WRAPPER, $MAXSIZE-48; \ REP;MOVSB; \ /* set up argument registers */ \ MOVQ regArgs+40(FP), R12; \ - CALL unspillArgs<>(SB); \ + CALL ·unspillArgs<ABIInternal>(SB); \ /* call function */ \ MOVQ f+8(FP), DX; \ PCDATA $PCDATA_StackMapIndex, $0; \ @@ -600,7 +600,7 @@ TEXT NAME(SB), WRAPPER, $MAXSIZE-48; \ CALL R12; \ /* copy register return values back */ \ MOVQ regArgs+40(FP), R12; \ - CALL spillArgs<>(SB); \ + CALL ·spillArgs<ABIInternal>(SB); \ MOVLQZX stackArgsSize+24(FP), CX; \ MOVLQZX stackRetOffset+28(FP), BX; \ MOVQ stackArgs+16(FP), DI; \ |