diff options
| author | David Chase <drchase@google.com> | 2021-03-09 20:43:49 -0500 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2021-05-06 11:58:39 +0000 |
| commit | b4ca1cec69f8248b77d8d8ce019943ced5235ed0 (patch) | |
| tree | a50d6cbba00b63315b7b22e7ea51b4bb3d8a093e /src/reflect | |
| parent | 1108cbe60b87196ce739ff8bce08c9862d6b61f0 (diff) | |
| download | go-b4ca1cec69f8248b77d8d8ce019943ced5235ed0.tar.gz go-b4ca1cec69f8248b77d8d8ce019943ced5235ed0.zip | |
cmd/compile: set unsayable "names" for regabi testing triggers
This disables the "testing names" for method names and
trailing input types passed to closure/interface/other calls.
The logic using the names remains, so that editing the change
to enable local testing is not too hard.
Also fixes broken build tag in reflect/abi_test.go
Updates #44816.
Change-Id: I3d222d2473c98d04ab6f1122ede9fea70c994af1
Reviewed-on: https://go-review.googlesource.com/c/go/+/300150
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/reflect')
| -rw-r--r-- | src/reflect/abi_test.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/reflect/abi_test.go b/src/reflect/abi_test.go index 224143c9bf..1a2a48b5ed 100644 --- a/src/reflect/abi_test.go +++ b/src/reflect/abi_test.go @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// +build goexperiment.regabi -//go:build goexperiment.regabi +//go:build goexperiment.regabireflect +// +build goexperiment.regabireflect package reflect_test @@ -16,6 +16,9 @@ import ( "testing/quick" ) +// As of early May 2021 this is no longer necessary for amd64, +// but it remains in case this is needed for the next register abi port. +// TODO (1.18) If enabling register ABI on additional architectures turns out not to need this, remove it. type MagicLastTypeNameForTestingRegisterABI struct{} func TestMethodValueCallABI(t *testing.T) { |