aboutsummaryrefslogtreecommitdiff
path: root/src/race.bash
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2015-02-22 12:41:32 -0500
committerRuss Cox <rsc@golang.org>2015-02-23 15:13:17 +0000
commit096b294f219eb9f348652c5e70d067ff51be89b2 (patch)
treeb50f78aa29284c11fa004db0037a6eb4504f0a3b /src/race.bash
parent5944cb8d1ae8903c30483f654a15a02a6e3c6e56 (diff)
downloadgo-096b294f219eb9f348652c5e70d067ff51be89b2.tar.gz
go-096b294f219eb9f348652c5e70d067ff51be89b2.zip
[dev.cc] cmd/go: fix expansion of 'std', add 'cmd'
The wildcard 'std' is defined in documentation to be all the packages in the Go standard library. It has also historically matched commands in the main repo, but as we implement core commands in Go, that becomes problematic. We need a wildcard that means just the library, and since 'std' is already documented to have that definition, make it so. Add a new wildcard 'cmd' for the commands in the main repo ($GOROOT). Commands that want both can say 'std cmd' (or 'cmd std') to get the effect of the old 'std'. Update make.bash etc to say both std and cmd most of the time. Exception: in race.bash, do not install race-enabled versions of the actual commands. This avoids trying to write binaries while using them, but more importantly it avoids enabling the race detector and its associated memory overhead for the already memory-hungry compilers. Change-Id: I26bb06cb13b636dfbe71a015ee0babeb270a0275 Reviewed-on: https://go-review.googlesource.com/5550 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/race.bash')
-rwxr-xr-xsrc/race.bash2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/race.bash b/src/race.bash
index 6225840168..b305c8f970 100755
--- a/src/race.bash
+++ b/src/race.bash
@@ -40,8 +40,6 @@ if [ ! -f make.bash ]; then
exit 1
fi
. ./make.bash --no-banner
-# golang.org/issue/5537 - we must build a race enabled cmd/cgo before trying to use it.
-go install -race cmd/cgo
go install -race std
# we must unset GOROOT_FINAL before tests, because runtime/debug requires