diff options
| author | Bryan C. Mills <bcmills@google.com> | 2021-12-16 12:32:39 -0500 |
|---|---|---|
| committer | Bryan Mills <bcmills@google.com> | 2021-12-17 02:00:14 +0000 |
| commit | 55a25aa6ca03143bef38be7f6d618df51c569a66 (patch) | |
| tree | 344f1e340ae9b3f78094306beba4f85058e04704 /src/net | |
| parent | 63077bfcf563e3f2ef96fa51203ed2fad71a371c (diff) | |
| download | go-55a25aa6ca03143bef38be7f6d618df51c569a66.tar.gz go-55a25aa6ca03143bef38be7f6d618df51c569a66.zip | |
net: lengthen arbitrary SetDeadline timeout by a few orders of magnitude
The "someTimeout" constant in the net test is “just to test that
net.Conn implementations don't explode when their SetFooDeadline
methods are called”. It was set to 10 seconds, which is short enough
that it could actually matter on some platforms.
Since the point of the constant is just to make sure methods don't
explode, we should set it to be at least a couple of orders of
magnitude longer than the test: then it is guaranteed not to have any
unintended side-effects.
Fixes #50227
Change-Id: If97ae7bef5e7f16b336d09ccc37f5ea2ea7e70b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/372796
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/net')
| -rw-r--r-- | src/net/conn_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net/conn_test.go b/src/net/conn_test.go index 3403eddfd3..d168dda08e 100644 --- a/src/net/conn_test.go +++ b/src/net/conn_test.go @@ -17,7 +17,7 @@ import ( // someTimeout is used just to test that net.Conn implementations // don't explode when their SetFooDeadline methods are called. // It isn't actually used for testing timeouts. -const someTimeout = 10 * time.Second +const someTimeout = 1 * time.Hour func TestConnAndListener(t *testing.T) { for i, network := range []string{"tcp", "unix", "unixpacket"} { |