aboutsummaryrefslogtreecommitdiff
path: root/src/go/ast/scope.go
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2024-03-27 10:08:25 -0400
committerGopher Robot <gobot@golang.org>2024-03-28 21:25:26 +0000
commitfae6eb5f2fc422447e3ca324c895503e9166d247 (patch)
treeb438a29916eb01d8646131c936249d18d38d265c /src/go/ast/scope.go
parent77d9cb8937ba54a8bc82efd7f56b2bda617e4f38 (diff)
downloadgo-fae6eb5f2fc422447e3ca324c895503e9166d247.tar.gz
go-fae6eb5f2fc422447e3ca324c895503e9166d247.zip
runtime: fix timer race introduced in CL 573455
There is a short window when timers.adjust could miss a timer update. Close that window. Does not change benchmark. goos: linux goarch: amd64 pkg: time cpu: AMD Ryzen 9 7950X 16-Core Processor │ s7base.txt │ s7.txt │ │ sec/op │ sec/op vs base │ AdjustTimers10000-32 239.9µ ± 5% 237.6µ ± 8% ~ (p=0.631 n=10) AdjustTimers10000SingleThread-32 1.686m ± 8% 1.710m ± 5% ~ (p=0.481 n=10) AdjustTimers10000NoReset-32 194.1µ ± 1% 190.8µ ± 2% -1.69% (p=0.023 n=10) AdjustTimers10000NoSleep-32 226.2µ ± 3% 222.9µ ± 3% ~ (p=0.143 n=10) AdjustTimers10000NoResetNoSleep-32 182.9µ ± 1% 180.9µ ± 2% ~ (p=0.165 n=10) goos: darwin goarch: arm64 pkg: time cpu: Apple M3 Pro │ m3base.txt │ m3.txt │ │ sec/op │ sec/op vs base │ AdjustTimers10000-12 269.3µ ± 2% 267.0µ ± 2% ~ (p=0.529 n=10) AdjustTimers10000SingleThread-12 1.176m ± 1% 1.213m ± 1% +3.15% (p=0.000 n=10) AdjustTimers10000NoReset-12 262.6µ ± 2% 261.4µ ± 3% ~ (p=0.123 n=10) AdjustTimers10000NoSleep-12 247.8µ ± 1% 246.5µ ± 1% ~ (p=0.393 n=10) AdjustTimers10000NoResetNoSleep-12 231.0µ ± 1% 232.3µ ± 1% ~ (p=0.684 n=10) Change-Id: Ifdfcdd5a25046027912a8b306644bde7ec2d3214 Reviewed-on: https://go-review.googlesource.com/c/go/+/574741 Auto-Submit: Russ Cox <rsc@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/go/ast/scope.go')
0 files changed, 0 insertions, 0 deletions