aboutsummaryrefslogtreecommitdiff
path: root/src/encoding
diff options
context:
space:
mode:
authorapocelipes <seve3r@outlook.com>2023-10-12 15:55:54 +0000
committerGopher Robot <gobot@golang.org>2023-10-12 20:48:17 +0000
commitcc13161a0d62fc1deab019996c17a7da1ff6a7f1 (patch)
tree187fc07e1808950f2e9389693274e6251d13bd63 /src/encoding
parent15a274b621b3654e9b4962a27c9d14ea51645b6c (diff)
downloadgo-cc13161a0d62fc1deab019996c17a7da1ff6a7f1.tar.gz
go-cc13161a0d62fc1deab019996c17a7da1ff6a7f1.zip
encoding/xml: use reflect.Value.IsZero
IsZero does the same thing, using this rather than writing it again. Change-Id: I62810ac2d1a6e189feac03b022c8931fb6993e19 GitHub-Last-Rev: 1d5fd10d96baf75e8b170a2c71949ff3d0884c46 GitHub-Pull-Request: golang/go#63519 Reviewed-on: https://go-review.googlesource.com/c/go/+/534935 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Diffstat (limited to 'src/encoding')
-rw-r--r--src/encoding/xml/marshal.go16
1 files changed, 6 insertions, 10 deletions
diff --git a/src/encoding/xml/marshal.go b/src/encoding/xml/marshal.go
index 7c52dd6d99..05b5542dfb 100644
--- a/src/encoding/xml/marshal.go
+++ b/src/encoding/xml/marshal.go
@@ -1120,16 +1120,12 @@ func isEmptyValue(v reflect.Value) bool {
switch v.Kind() {
case reflect.Array, reflect.Map, reflect.Slice, reflect.String:
return v.Len() == 0
- case reflect.Bool:
- return !v.Bool()
- case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
- return v.Int() == 0
- case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
- return v.Uint() == 0
- case reflect.Float32, reflect.Float64:
- return v.Float() == 0
- case reflect.Interface, reflect.Pointer:
- return v.IsNil()
+ case reflect.Bool,
+ reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64,
+ reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr,
+ reflect.Float32, reflect.Float64,
+ reflect.Interface, reflect.Pointer:
+ return v.IsZero()
}
return false
}