diff options
| author | Ian Lance Taylor <iant@golang.org> | 2023-02-22 13:00:14 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-02-22 23:19:29 +0000 |
| commit | e7cfcda67d430a6e3cf4e8dfef27416870a2b007 (patch) | |
| tree | aace311ed4eef4a1b19d35433873df1b375dec97 /src/debug | |
| parent | 06b67591e7861d813e94fa76434af9c778d81cf5 (diff) | |
| download | go-e7cfcda67d430a6e3cf4e8dfef27416870a2b007.tar.gz go-e7cfcda67d430a6e3cf4e8dfef27416870a2b007.zip | |
debug/macho: don't crash if dynamic symtab with no symtab
No test case because the problem can only happen for invalid data. Let
the fuzzer find cases like this.
For #47653
Fixes #58642
Change-Id: I19fee0dc9bd6239b520c15182b8f1e57bb0049bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/470397
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/debug')
| -rw-r--r-- | src/debug/macho/file.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/debug/macho/file.go b/src/debug/macho/file.go index 9806c270bf..3e339c32c6 100644 --- a/src/debug/macho/file.go +++ b/src/debug/macho/file.go @@ -350,7 +350,9 @@ func NewFile(r io.ReaderAt) (*File, error) { if err := binary.Read(b, bo, &hdr); err != nil { return nil, err } - if hdr.Iundefsym > uint32(len(f.Symtab.Syms)) { + if f.Symtab == nil { + return nil, &FormatError{offset, "dynamic symbol table seen before any ordinary symbol table", nil} + } else if hdr.Iundefsym > uint32(len(f.Symtab.Syms)) { return nil, &FormatError{offset, fmt.Sprintf( "undefined symbols index in dynamic symbol table command is greater than symbol table length (%d > %d)", hdr.Iundefsym, len(f.Symtab.Syms)), nil} |