diff options
| author | Zeke Lu <lvzecai@gmail.com> | 2022-10-26 11:41:27 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-10-26 22:26:02 +0000 |
| commit | 264753c0432c728989970786398c2bcf241a43dd (patch) | |
| tree | e9d8f0e4cb77f9d95415725c8e3443dd7bf354f6 /src/debug | |
| parent | ed24b37fd2b0c242525eb2203d90627c4be1b149 (diff) | |
| download | go-264753c0432c728989970786398c2bcf241a43dd.tar.gz go-264753c0432c728989970786398c2bcf241a43dd.zip | |
debug/elf: guard access to File.gnuVersym
The size of gnuVersym should be multiples of 2. If not, the input is
invalid. No Library and Version information is added to sym in this
case. The current implementation of gnuVersion does not report errors
for invalid input.
While at here, bring back the comment that states that the undef entry
at the beginning is skipped. This is not an off-by-one error.
No test case because the problem can only happen for invalid data. Let
the fuzzer find cases like this.
Fixes #56429.
Change-Id: Ia39ad8bd509088a81cc77f7a76e23185d40a5765
GitHub-Last-Rev: 3be0cc1b1522874cf5dc509678aa6a5658b6bad5
GitHub-Pull-Request: golang/go#56431
Reviewed-on: https://go-review.googlesource.com/c/go/+/445555
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Meng Zhuo <mzh@golangcn.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/debug')
| -rw-r--r-- | src/debug/elf/file.go | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/debug/elf/file.go b/src/debug/elf/file.go index 7c5ac86c0a..88b957657b 100644 --- a/src/debug/elf/file.go +++ b/src/debug/elf/file.go @@ -1570,12 +1570,16 @@ func (f *File) gnuVersionInit(str []byte) bool { // gnuVersion adds Library and Version information to sym, // which came from offset i of the symbol table. func (f *File) gnuVersion(i int) (library string, version string) { - // Each entry is two bytes. + // Each entry is two bytes; skip undef entry at beginning. i = (i + 1) * 2 if i >= len(f.gnuVersym) { return } - j := int(f.ByteOrder.Uint16(f.gnuVersym[i:])) + s := f.gnuVersym[i:] + if len(s) < 2 { + return + } + j := int(f.ByteOrder.Uint16(s)) if j < 2 || j >= len(f.gnuNeed) { return } |