diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2019-04-22 14:39:55 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2019-04-24 00:56:36 +0000 |
| commit | ca0c449a6b1c6ecc75169f93cffa8a5630740030 (patch) | |
| tree | decb56cb6c8eb3e7e910ee090f3694465af30e60 /src/cmd/vet | |
| parent | de050717f1b668dfd196f1dc4d18c77d03f3afb4 (diff) | |
| download | go-ca0c449a6b1c6ecc75169f93cffa8a5630740030.tar.gz go-ca0c449a6b1c6ecc75169f93cffa8a5630740030.zip | |
bytes, internal/bytealg: simplify Equal
The compiler has advanced enough that it is cheaper
to convert to strings than to go through the assembly
trampolines to call runtime.memequal.
Simplify Equal accordingly, and cull dead code from bytealg.
While we're here, simplify Equal's documentation.
Fixes #31587
Change-Id: Ie721d33f9a6cbd86b1d873398b20e7882c2c63e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/173323
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/vet')
| -rw-r--r-- | src/cmd/vet/all/whitelist/arm.txt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/cmd/vet/all/whitelist/arm.txt b/src/cmd/vet/all/whitelist/arm.txt index abcb38b003..81a1f1831e 100644 --- a/src/cmd/vet/all/whitelist/arm.txt +++ b/src/cmd/vet/all/whitelist/arm.txt @@ -12,4 +12,3 @@ runtime/tls_arm.s: [arm] load_g: function load_g missing Go declaration runtime/tls_arm.s: [arm] _initcgo: function _initcgo missing Go declaration runtime/internal/atomic/asm_arm.s: [arm] cas: function cas missing Go declaration -internal/bytealg/equal_arm.s: [arm] Equal: invalid MOVW of ret+24(FP); bool is 1-byte value |