aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/vet
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2019-05-08 15:10:29 -0400
committerRuss Cox <rsc@golang.org>2019-05-09 21:13:25 +0000
commitb4a472b1c3b7ae48cf6128e5f0594439dc20d081 (patch)
tree9bfef35b7adf7e8081e4973ba6478883df4c9e60 /src/cmd/vet
parent60f67631a6c9e75ffd2829fcca56ac45d9baf019 (diff)
downloadgo-b4a472b1c3b7ae48cf6128e5f0594439dc20d081.tar.gz
go-b4a472b1c3b7ae48cf6128e5f0594439dc20d081.zip
syscall: fix vet complaints for all dragonfly, freebsd, netbsd, openbsd
Working toward making the tree vet-safe instead of having so many exceptions in cmd/vet/all/whitelist. This CL makes "go vet -unsafeptr=false runtime" happy for these GOOSes, while keeping "GO_BUILDER_NAME=misc-vetall go tool dist test" happy too. For #31916. Change-Id: Id2e1223497bd0cd6e880cd81f3ece6363e58219f Reviewed-on: https://go-review.googlesource.com/c/go/+/176104 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/cmd/vet')
-rw-r--r--src/cmd/vet/all/whitelist/dragonfly_amd64.txt6
-rw-r--r--src/cmd/vet/all/whitelist/freebsd_386.txt10
-rw-r--r--src/cmd/vet/all/whitelist/freebsd_amd64.txt5
-rw-r--r--src/cmd/vet/all/whitelist/netbsd_386.txt10
-rw-r--r--src/cmd/vet/all/whitelist/netbsd_arm.txt3
-rw-r--r--src/cmd/vet/all/whitelist/openbsd_386.txt10
6 files changed, 0 insertions, 44 deletions
diff --git a/src/cmd/vet/all/whitelist/dragonfly_amd64.txt b/src/cmd/vet/all/whitelist/dragonfly_amd64.txt
deleted file mode 100644
index 0db5503ef0..0000000000
--- a/src/cmd/vet/all/whitelist/dragonfly_amd64.txt
+++ /dev/null
@@ -1,6 +0,0 @@
-// dragonfly/amd64-specific vet whitelist. See readme.txt for details.
-
-
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 8(SP) should be num+0(FP)
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 16(SP) should be a1+8(FP)
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 24(SP) should be a2+16(FP)
diff --git a/src/cmd/vet/all/whitelist/freebsd_386.txt b/src/cmd/vet/all/whitelist/freebsd_386.txt
index b5218e814f..ed83a3e5ac 100644
--- a/src/cmd/vet/all/whitelist/freebsd_386.txt
+++ b/src/cmd/vet/all/whitelist/freebsd_386.txt
@@ -6,13 +6,3 @@ runtime/sys_freebsd_386.s: [386] sigtramp: unknown variable info
runtime/sys_freebsd_386.s: [386] sigtramp: unknown variable context
runtime/sys_freebsd_386.s: [386] sigtramp: unknown variable context
runtime/sys_freebsd_386.s: [386] i386_set_ldt: function i386_set_ldt missing Go declaration
-syscall/asm_unix_386.s: [386] Syscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 4(SP) should be num+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 4(SP) should be trap+0(FP)
diff --git a/src/cmd/vet/all/whitelist/freebsd_amd64.txt b/src/cmd/vet/all/whitelist/freebsd_amd64.txt
deleted file mode 100644
index 356be022cc..0000000000
--- a/src/cmd/vet/all/whitelist/freebsd_amd64.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-// freebsd/amd64-specific vet whitelist. See readme.txt for details.
-
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 8(SP) should be num+0(FP)
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 16(SP) should be a1+8(FP)
-syscall/asm9_unix2_amd64.s: [amd64] Syscall9: 24(SP) should be a2+16(FP)
diff --git a/src/cmd/vet/all/whitelist/netbsd_386.txt b/src/cmd/vet/all/whitelist/netbsd_386.txt
index 608021cae4..bd2151de20 100644
--- a/src/cmd/vet/all/whitelist/netbsd_386.txt
+++ b/src/cmd/vet/all/whitelist/netbsd_386.txt
@@ -7,13 +7,3 @@ runtime/sys_netbsd_386.s: [386] sigtramp: unknown variable signo
runtime/sys_netbsd_386.s: [386] sigtramp: unknown variable info
runtime/sys_netbsd_386.s: [386] sigtramp: unknown variable context
-syscall/asm_unix_386.s: [386] Syscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 4(SP) should be num+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 4(SP) should be trap+0(FP)
diff --git a/src/cmd/vet/all/whitelist/netbsd_arm.txt b/src/cmd/vet/all/whitelist/netbsd_arm.txt
deleted file mode 100644
index 59b261097f..0000000000
--- a/src/cmd/vet/all/whitelist/netbsd_arm.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-// netbsd/arm-specific vet whitelist. See readme.txt for details.
-
-syscall/asm_netbsd_arm.s: [arm] Syscall9: unknown variable trap; offset 0 is num+0(FP)
diff --git a/src/cmd/vet/all/whitelist/openbsd_386.txt b/src/cmd/vet/all/whitelist/openbsd_386.txt
index bfbf4d9c56..acda942e28 100644
--- a/src/cmd/vet/all/whitelist/openbsd_386.txt
+++ b/src/cmd/vet/all/whitelist/openbsd_386.txt
@@ -3,13 +3,3 @@
runtime/sys_openbsd_386.s: [386] sigtramp: unknown variable signo
runtime/sys_openbsd_386.s: [386] sigtramp: unknown variable info
runtime/sys_openbsd_386.s: [386] sigtramp: unknown variable context
-syscall/asm_unix_386.s: [386] Syscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall6: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] Syscall9: 4(SP) should be num+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall: 4(SP) should be trap+0(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 8(SP) should be a1+4(FP)
-syscall/asm_unix_386.s: [386] RawSyscall6: 4(SP) should be trap+0(FP)