diff options
| author | Russ Cox <rsc@golang.org> | 2019-05-08 18:40:58 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2019-05-09 21:13:46 +0000 |
| commit | 56c1cf315d0178ee522f6f305150ed83ec4df816 (patch) | |
| tree | 8e5d15c7a1a4d00f93154092cdd293c7b3079ee8 /src/cmd/vet | |
| parent | 13723d44a0eea725215274070b53a023d52582c9 (diff) | |
| download | go-56c1cf315d0178ee522f6f305150ed83ec4df816.tar.gz go-56c1cf315d0178ee522f6f305150ed83ec4df816.zip | |
runtime: fix vet complaints for all nacl
Working toward making the tree vet-safe instead of having
so many exceptions in cmd/vet/all/whitelist.
This CL makes "go vet -unsafeptr=false runtime" happy for nacl/*,
while keeping "GO_BUILDER_NAME=misc-vetall go tool dist test" happy too.
For #31916.
Change-Id: I6adb4a7b0c2b03d901fba37f9c05e74e5b7b6691
Reviewed-on: https://go-review.googlesource.com/c/go/+/176107
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/vet')
| -rw-r--r-- | src/cmd/vet/all/whitelist/nacl_386.txt | 10 | ||||
| -rw-r--r-- | src/cmd/vet/all/whitelist/nacl_amd64p32.txt | 18 | ||||
| -rw-r--r-- | src/cmd/vet/all/whitelist/nacl_arm.txt | 4 |
3 files changed, 0 insertions, 32 deletions
diff --git a/src/cmd/vet/all/whitelist/nacl_386.txt b/src/cmd/vet/all/whitelist/nacl_386.txt deleted file mode 100644 index 9e756d1bd5..0000000000 --- a/src/cmd/vet/all/whitelist/nacl_386.txt +++ /dev/null @@ -1,10 +0,0 @@ -// nacl/386-specific vet whitelist. See readme.txt for details. - -runtime/sys_nacl_386.s: [386] nacl_clock_gettime: function nacl_clock_gettime missing Go declaration -runtime/sys_nacl_386.s: [386] sigtramp: use of 20(SP) points beyond argument frame -runtime/sys_nacl_386.s: [386] sigtramp: use of 4(SP) points beyond argument frame -runtime/sys_nacl_386.s: [386] sigtramp: unknown variable ctxt -runtime/sys_nacl_386.s: [386] sigtramp: use of 8(SP) points beyond argument frame -runtime/sys_nacl_386.s: [386] sigtramp: use of 12(SP) points beyond argument frame -runtime/sys_nacl_386.s: [386] sigtramp: use of 20(SP) points beyond argument frame -runtime/sys_nacl_386.s: [386] sigtramp: unknown variable ctxt diff --git a/src/cmd/vet/all/whitelist/nacl_amd64p32.txt b/src/cmd/vet/all/whitelist/nacl_amd64p32.txt deleted file mode 100644 index fb95a360a6..0000000000 --- a/src/cmd/vet/all/whitelist/nacl_amd64p32.txt +++ /dev/null @@ -1,18 +0,0 @@ -// nacl/amd64p32-specific vet whitelist. See readme.txt for details. - -// reflect trampolines intentionally omit arg size. Same for morestack. -runtime/asm_amd64p32.s: [amd64p32] morestack: use of 8(SP) points beyond argument frame -runtime/asm_amd64p32.s: [amd64p32] morestack: use of 16(SP) points beyond argument frame -runtime/asm_amd64p32.s: [amd64p32] morestack: use of 8(SP) points beyond argument frame - -runtime/sys_nacl_amd64p32.s: [amd64p32] sigtramp: unknown variable ctxt -runtime/sys_nacl_amd64p32.s: [amd64p32] sigtramp: unknown variable ctxt -runtime/sys_nacl_amd64p32.s: [amd64p32] sigtramp: unknown variable ctxt -runtime/sys_nacl_amd64p32.s: [amd64p32] nacl_sysinfo: function nacl_sysinfo missing Go declaration -runtime/sys_nacl_amd64p32.s: [amd64p32] nacl_clock_gettime: function nacl_clock_gettime missing Go declaration - -// Clearer using FP than SP, but that requires named offsets. -runtime/asm_amd64p32.s: [amd64p32] rt0_go: unknown variable argc -runtime/asm_amd64p32.s: [amd64p32] rt0_go: unknown variable argv - -runtime/asm_amd64p32.s: [amd64p32] asmcgocall: RET without writing to 4-byte ret+8(FP) diff --git a/src/cmd/vet/all/whitelist/nacl_arm.txt b/src/cmd/vet/all/whitelist/nacl_arm.txt deleted file mode 100644 index 08a613dd56..0000000000 --- a/src/cmd/vet/all/whitelist/nacl_arm.txt +++ /dev/null @@ -1,4 +0,0 @@ -// nacl/arm-specific vet whitelist. See readme.txt for details. - -runtime/sys_nacl_arm.s: [arm] nacl_clock_gettime: function nacl_clock_gettime missing Go declaration -runtime/sys_nacl_arm.s: [arm] nacl_sysinfo: function nacl_sysinfo missing Go declaration |