diff options
author | Muhammad Falak R Wani <falakreyaz@gmail.com> | 2018-06-15 00:07:32 +0530 |
---|---|---|
committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-08-21 02:45:00 +0000 |
commit | 9087d13ec3e39e50aae6c6a8cf99dc66225ab132 (patch) | |
tree | e8a7e594f459a6ef9af9ec8a60680084380ea593 /src/cmd/objdump | |
parent | a0212aa6273395c400092383bbdebc251ebacd2d (diff) | |
download | go-9087d13ec3e39e50aae6c6a8cf99dc66225ab132.tar.gz go-9087d13ec3e39e50aae6c6a8cf99dc66225ab132.zip |
cmd/objdump: defer closing the file after opening
Remove the os.Exit(0) to honor the deferred closing of the file.
Change-Id: Iaa9304d8203c8fec0ec728af669a94eadd36905c
Reviewed-on: https://go-review.googlesource.com/118915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/objdump')
-rw-r--r-- | src/cmd/objdump/main.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cmd/objdump/main.go b/src/cmd/objdump/main.go index 71636990a1..6a60697ebd 100644 --- a/src/cmd/objdump/main.go +++ b/src/cmd/objdump/main.go @@ -75,6 +75,7 @@ func main() { if err != nil { log.Fatal(err) } + defer f.Close() dis, err := f.Disasm() if err != nil { @@ -87,7 +88,6 @@ func main() { case 1: // disassembly of entire object dis.Print(os.Stdout, symRE, 0, ^uint64(0), *printCode) - os.Exit(0) case 3: // disassembly of PC range @@ -100,6 +100,5 @@ func main() { log.Fatalf("invalid end PC: %v", err) } dis.Print(os.Stdout, symRE, start, end, *printCode) - os.Exit(0) } } |