diff options
| author | Cherry Zhang <cherryyz@google.com> | 2017-10-06 15:00:02 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2017-11-01 18:23:58 +0000 |
| commit | 7bd0b6100070d6a24458eded77228d37bfa1eb76 (patch) | |
| tree | f4b4235e4443e1e7cbe8aa06c54ce51c030c97d4 /src/cmd/objdump | |
| parent | 85c32c3744d879392c43a4ec4772199b28c9b34e (diff) | |
| download | go-7bd0b6100070d6a24458eded77228d37bfa1eb76.tar.gz go-7bd0b6100070d6a24458eded77228d37bfa1eb76.zip | |
cmd/internal/goobj: accept int64 in readInt
The counter part, writeInt in cmd/internal/obj, writes int64s.
So the reader side should also read int64s. This may cause a
larger range of values being accepted, some of which should
not be that large. This is probably ok: for example, for
size/index/length, the very large value (due to corruption)
may be well past the end and causes other errors. And we did
not do much bound check anyway.
One exmaple where this matters is ARM32's object file. For one
type of relocation it encodes the instruction into Reloc.Add
field (which itself may be problematic and worth fix) and the
instruction encoding overflows int32, causing ARM32 object
file being rejected by goobj (and so objdump and nm) before.
Unskip ARM32 object file tests in goobj, nm, and objdump.
Updates #19811.
Change-Id: Ia46c2b68df5f1c5204d6509ceab6416ad6372315
Reviewed-on: https://go-review.googlesource.com/69010
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/cmd/objdump')
| -rw-r--r-- | src/cmd/objdump/objdump_test.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go index 100e9fcb5f..f0771cdde9 100644 --- a/src/cmd/objdump/objdump_test.go +++ b/src/cmd/objdump/objdump_test.go @@ -198,8 +198,6 @@ func TestDisasmExtld(t *testing.T) { func TestDisasmGoobj(t *testing.T) { switch runtime.GOARCH { - case "arm": - t.Skipf("skipping on %s, issue 19811", runtime.GOARCH) case "mips", "mipsle", "mips64", "mips64le": t.Skipf("skipping on %s, issue 12559", runtime.GOARCH) case "s390x": |