diff options
| author | Michael Matloob <matloob@golang.org> | 2019-12-26 16:06:49 -0500 |
|---|---|---|
| committer | Michael Matloob <matloob@golang.org> | 2020-01-06 17:32:58 +0000 |
| commit | fab2e86ba230389b270940c4e1a8e30c2bbb59f2 (patch) | |
| tree | 744d642b567a959845c6e13aee96de8ae669f420 /src/cmd/go/testdata/script/README | |
| parent | 57b22c51162035a52fdf09f043b1fed63faa28bc (diff) | |
| download | go-fab2e86ba230389b270940c4e1a8e30c2bbb59f2.tar.gz go-fab2e86ba230389b270940c4e1a8e30c2bbb59f2.zip | |
cmd/go: convert some testcases to the script framework
This change converts TestFatalInBenchmarkCauseNonZeroExitStatus,
TestBenchmarkLabels and TestWildCardsDoNotLookInUselessDirectories
to the script framework so they can run in parallel. These tests
used the testdata directory so they didn't call tg.parallel, because
they couldn't be sure the testdata directory wasn't being
modified while they were being run.
The tests are converted to the script framework instead of being modified
because the script framework tests are easier to read and are self-contained.
Also remove the directory src/cmd/go/testdata/src/badc. The testcase
that used it, "TestDisallowedCSourceFiles" was deleted in
golang.org/cl/19613.
Updates #17751
Change-Id: I0b9b417ae1a9b148067a3e5f8531229f3414f104
Reviewed-on: https://go-review.googlesource.com/c/go/+/212620
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/testdata/script/README')
| -rw-r--r-- | src/cmd/go/testdata/script/README | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/go/testdata/script/README b/src/cmd/go/testdata/script/README index 2782a09707..7dba6b394c 100644 --- a/src/cmd/go/testdata/script/README +++ b/src/cmd/go/testdata/script/README @@ -40,7 +40,7 @@ Scripts also have access to these other environment variables: goversion=<current Go version; for example, 1.12> :=<OS-specific path list separator> -The scripts supporting files are unpacked relative to $GOPATH/src (aka $WORK/gopath/src) +The scripts' supporting files are unpacked relative to $GOPATH/src (aka $WORK/gopath/src) and then the script begins execution in that directory as well. Thus the example above runs in $WORK/gopath/src with GOPATH=$WORK/gopath and $WORK/gopath/src/hello.go containing the listed contents. |