diff options
| author | Bryan C. Mills <bcmills@google.com> | 2020-06-05 16:08:08 -0400 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2020-06-09 02:49:06 +0000 |
| commit | cacac8bdc5c93e7bc71df71981fdf32dded017bf (patch) | |
| tree | a446c52808abf100906c992122656a45b8e51c69 /src/cmd/go/testdata/script/README | |
| parent | e64675a79fef5924f268425de021372df874010e (diff) | |
| download | go-cacac8bdc5c93e7bc71df71981fdf32dded017bf.tar.gz go-cacac8bdc5c93e7bc71df71981fdf32dded017bf.zip | |
cmd/dist: do not unset GOROOT_FINAL prior to running tests
Also do not unset it by default in the tests for cmd/go.
GOROOT_FINAL affects the GOROOT value embedded in binaries,
such as 'cmd/cgo'. If its value changes and a build command
is performed that depends on one of those binaries, the binary
would be spuriously rebuilt.
Instead, only unset it in the specific tests that make assumptions
about the GOROOT paths embedded in specific compiled binaries.
That may cause those tests to do a little extra rebuilding when
GOROOT_FINAL is set, but that little bit of extra rebuilding
seems preferable to spuriously-stale binaries.
Fixes #39385
Change-Id: I7c87b1519bb5bcff64babf1505fd1033ffa4f4fb
Reviewed-on: https://go-review.googlesource.com/c/go/+/236819
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Diffstat (limited to 'src/cmd/go/testdata/script/README')
| -rw-r--r-- | src/cmd/go/testdata/script/README | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/go/testdata/script/README b/src/cmd/go/testdata/script/README index c7fa7cfef5..76d6651718 100644 --- a/src/cmd/go/testdata/script/README +++ b/src/cmd/go/testdata/script/README @@ -34,6 +34,7 @@ Scripts also have access to these other environment variables: GOPATH=$WORK/gopath GOPROXY=<local module proxy serving from cmd/go/testdata/mod> GOROOT=<actual GOROOT> + GOROOT_FINAL=<actual GOROOT_FINAL> TESTGO_GOROOT=<GOROOT used to build cmd/go, for use in tests that may change GOROOT> HOME=/no-home PATH=<actual PATH> |