diff options
| author | Jay Conrod <jayconrod@google.com> | 2020-02-25 11:00:08 -0500 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2020-03-11 17:31:14 +0000 |
| commit | 576fa692774137633b09dd244e1de36993dd2803 (patch) | |
| tree | 611c233ac7c050e802f0d3d82e4590a9337548db /src/cmd/go/testdata/script/README | |
| parent | 093049b3709eda7537ece92a2991918cf53782d6 (diff) | |
| download | go-576fa692774137633b09dd244e1de36993dd2803.tar.gz go-576fa692774137633b09dd244e1de36993dd2803.zip | |
cmd/go: extract module zip files in place
Previously, we extracted module zip files to temporary directories
with random names, then renamed them to their final locations. This
failed with ERROR_ACCESS_DENIED on Windows if any file in the
temporary was open. Antivirus programs did this occasionally. Retrying
the rename did not work (CL 220978).
With this change, we extract module zip files in place. We create a
.partial file alongside the .lock file to indicate a directory is not
fully populated, and we delete this at the end of the process.
Updates #36568
Change-Id: I75c09df879a602841f3459322c021896292b2fdb
Reviewed-on: https://go-review.googlesource.com/c/go/+/221157
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Diffstat (limited to 'src/cmd/go/testdata/script/README')
| -rw-r--r-- | src/cmd/go/testdata/script/README | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/go/testdata/script/README b/src/cmd/go/testdata/script/README index 71d38161d5..65b4c78090 100644 --- a/src/cmd/go/testdata/script/README +++ b/src/cmd/go/testdata/script/README @@ -36,6 +36,7 @@ Scripts also have access to these other environment variables: HOME=/no-home PATH=<actual PATH> TMPDIR=$WORK/tmp + GODEBUG=<actual GODEBUG> devnull=<value of os.DevNull> goversion=<current Go version; for example, 1.12> :=<OS-specific path list separator> |