diff options
| author | Shenghou Ma <minux@golang.org> | 2018-12-13 23:55:22 -0500 |
|---|---|---|
| committer | Minux Ma <minux@golang.org> | 2018-12-15 01:38:39 +0000 |
| commit | 281ce28c5048416dce9379405cc061b2f3662c84 (patch) | |
| tree | e4c3eeb30e1b3f96ebbce3ea96f98023ddab5a41 /src/cmd/go/testdata/script/README | |
| parent | fd323a8cffc11c92366243c4d26cb3ead507dc84 (diff) | |
| download | go-281ce28c5048416dce9379405cc061b2f3662c84.tar.gz go-281ce28c5048416dce9379405cc061b2f3662c84.zip | |
cmd/link: fix in-package syso linking
CL 146297 ignored archive members with short names that don't have
the .o suffix, however, it also ignored .syso files as well.
This change restores the original .syso behavior and adds a test.
As the test is basically following a shell script, we make use of
the existing cmd/go/testdata/script framework. To support running
C compiler in the script, we added a `cc` command, which runs the
C compiler along with correct platform specific arguments.
Fixes #29253.
Change-Id: If8520151c4d6a74ab9fe84d34bff9a4480688815
Reviewed-on: https://go-review.googlesource.com/c/154109
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Diffstat (limited to 'src/cmd/go/testdata/script/README')
| -rw-r--r-- | src/cmd/go/testdata/script/README | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/cmd/go/testdata/script/README b/src/cmd/go/testdata/script/README index 76d4b36b01..a7b50fff16 100644 --- a/src/cmd/go/testdata/script/README +++ b/src/cmd/go/testdata/script/README @@ -84,6 +84,10 @@ when testing.Short() is false. The commands are: +- [!] cc args... [&] + Run the C compiler, the platform specific flags (i.e. `go env GOGCCFLAGS`) will be + added automatically before args. + - cd dir Change to the given directory for future commands. |