diff options
author | Russ Cox <rsc@golang.org> | 2023-06-01 13:25:56 -0400 |
---|---|---|
committer | Gopher Robot <gobot@golang.org> | 2023-06-01 21:32:23 +0000 |
commit | 8035de592fbc782d27eb78e914ca4e04ec991a3f (patch) | |
tree | 2f3843fc1fca4d39feb4deda3eba273ca6fbc9ee /src/cmd/go/internal/modload/load.go | |
parent | 9f450041c54cb15a5757e54dcad5474fc4a0b871 (diff) | |
download | go-8035de592fbc782d27eb78e914ca4e04ec991a3f.tar.gz go-8035de592fbc782d27eb78e914ca4e04ec991a3f.zip |
cmd/go: add base.Error and base.Fatal
Many many places in the go command use
base.Errorf("go: %v", err)
or
base.Fatalf("go: %v", err)
Introduce Error(error) and Fatal(error) to do this
and update all call sites (global search and replace).
The new Error gives us the opportunity to unwrap
a multierror and add the go prefix to each line,
which is the motivation for this change.
(We want to start returning a multierror from LoadModFile
and LoadModGraph.)
For #57001.
Change-Id: I9613653b94808224146077c30d22f814d4e19eed
Reviewed-on: https://go-review.googlesource.com/c/go/+/499980
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/cmd/go/internal/modload/load.go')
-rw-r--r-- | src/cmd/go/internal/modload/load.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/cmd/go/internal/modload/load.go b/src/cmd/go/internal/modload/load.go index 8f1eb1098bd..0a06b1b1253 100644 --- a/src/cmd/go/internal/modload/load.go +++ b/src/cmd/go/internal/modload/load.go @@ -430,7 +430,7 @@ func LoadPackages(ctx context.Context, opts PackageOpts, patterns ...string) (ma // preserve checksums for) additional entities from compatRS, which are // only needed for compatibility with ld.TidyCompatibleVersion. if err := modfetch.WriteGoSum(ctx, keep, mustHaveCompleteRequirements()); err != nil { - base.Fatalf("go: %v", err) + base.Fatal(err) } } } @@ -451,7 +451,7 @@ func LoadPackages(ctx context.Context, opts PackageOpts, patterns ...string) (ma if !ExplicitWriteGoMod && opts.ResolveMissingImports { if err := commitRequirements(ctx, WriteOpts{}); err != nil { - base.Fatalf("go: %v", err) + base.Fatal(err) } } @@ -714,7 +714,7 @@ func ImportFromFiles(ctx context.Context, gofiles []string) { tags := imports.Tags() imports, testImports, err := imports.ScanFiles(gofiles, tags) if err != nil { - base.Fatalf("go: %v", err) + base.Fatal(err) } loaded = loadFromRoots(ctx, loaderParams{ @@ -734,7 +734,7 @@ func ImportFromFiles(ctx context.Context, gofiles []string) { if !ExplicitWriteGoMod { if err := commitRequirements(ctx, WriteOpts{}); err != nil { - base.Fatalf("go: %v", err) + base.Fatal(err) } } } |