diff options
| author | Austin Clements <austin@google.com> | 2023-05-25 09:25:05 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-05-25 15:34:13 +0000 |
| commit | f4086d36862d8fd41af90356c894d04d3ff58203 (patch) | |
| tree | 0be562bd0dc3d269d7e2439b5693e1a260307cf5 /src/cmd/dist/test.go | |
| parent | d23669db7de13aec74296ae9bed8bb707f83b773 (diff) | |
| download | go-f4086d36862d8fd41af90356c894d04d3ff58203.tar.gz go-f4086d36862d8fd41af90356c894d04d3ff58203.zip | |
cmd/dist: drop wasitest from special list
CL 498255 made runtime/internal/wasitest compatible with all platforms
so that "go test std" works again. This means it no longer has to be
in the special dist test list.
While we're here explain the purpose of this list better and implore
people to please not expand it, since almost any addition is a sign
that "go test std cmd" no longer works.
Change-Id: I31c7fb767787fa587f65c2697aed9ed43e95fb18
Reviewed-on: https://go-review.googlesource.com/c/go/+/498256
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Diffstat (limited to 'src/cmd/dist/test.go')
| -rw-r--r-- | src/cmd/dist/test.go | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index f16bf32bbf..f148fb97b5 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -573,9 +573,17 @@ func (t *tester) registerRaceBenchTest(pkg string) { func (t *tester) registerTests() { // registerStdTestSpecially tracks import paths in the standard library // whose test registration happens in a special way. + // + // These tests *must* be able to run normally as part of "go test std cmd", + // even if they are also registered separately by dist, because users often + // run go test directly. Use skips or build tags in preference to expanding + // this list. registerStdTestSpecially := map[string]bool{ - "runtime/internal/wasitest": true, // Registered at the bottom as a host test. - "cmd/internal/testdir": true, // Registered at the bottom with sharding. + // testdir can run normally as part of "go test std cmd", but because + // it's a very large test, we register is specially as several shards to + // enable better load balancing on sharded builders. Ideally the build + // system would know how to shard any large test package. + "cmd/internal/testdir": true, } // Fast path to avoid the ~1 second of `go list std cmd` when |