diff options
| author | Than McIntosh <thanm@google.com> | 2022-11-22 10:42:25 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-11-22 16:07:28 +0000 |
| commit | 9160e15494ed03967b86ddc1a601b659b3243fd0 (patch) | |
| tree | d0906d55085c06743f49c47968115ace2babb27e /src/cmd/dist/test.go | |
| parent | 5c9a506de17bdeb692e6e12d5ab56a06c11b042c (diff) | |
| download | go-9160e15494ed03967b86ddc1a601b659b3243fd0.tar.gz go-9160e15494ed03967b86ddc1a601b659b3243fd0.zip | |
cmd/dist: skip -race w/ external linkage on windows 2008
Add a skip for the external-linkage part of the race detector test for
elderly versions of windows, until the underlying cause for the problem
can be determined.
Updates #56904.
Change-Id: I3e8650ff66f34efefabcd6bc343d57124539901b
Reviewed-on: https://go-review.googlesource.com/c/go/+/452763
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/dist/test.go')
| -rw-r--r-- | src/cmd/dist/test.go | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index eadca9c08f..316a9b9ddd 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1602,14 +1602,18 @@ func (t *tester) registerRaceTests() { // t.registerTest("race:misc/cgo/test", hdr, &goTest{dir: "../misc/cgo/test", race: true, env: []string{"GOTRACEBACK=2"}}) } if t.extLink() { - // Test with external linking; see issue 9133. - t.registerTest("race:external", hdr, - &goTest{ - race: true, - ldflags: "-linkmode=external", - runTests: "TestParse|TestEcho|TestStdinCloseRace", - pkgs: []string{"flag", "os/exec"}, - }) + if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "windows-amd64-2008") { + log.Printf("skipping -race with external linkage on older windows builder, see https://github.com/golang/go/issues/56904 for details") + } else { + // Test with external linking; see issue 9133. + t.registerTest("race:external", hdr, + &goTest{ + race: true, + ldflags: "-linkmode=external", + runTests: "TestParse|TestEcho|TestStdinCloseRace", + pkgs: []string{"flag", "os/exec"}, + }) + } } } |